simple workaround for package names containing dashes #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Djailla
suggested changes
Oct 30, 2019
| all_versions = self._get_simple_html_package_info_versions( | ||
| package_name, response) | ||
| if not all_versions: | ||
| # print("{}: NO VERSIONS AVAILLABLE".format( package_name)) |
| # print("{}: NO VERSIONS AVAILLABLE".format( package_name)) | ||
| fixed_name = package_name | ||
| # if we find a dash, presume earlier name used an underscore | ||
| if '-' in package_name: |
There was a problem hiding this comment.
You need to add a test to cover this part of code
|
A test for 100% coverage would be nice :) |
|
Tests fail when an index url is assigned in a local pip.conf file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using pip 19.2.3, the package names contain dashes, rather than underscores.
To reproduce bug:
Create new virtual environment.
The PR fixes this problem, but also raises a runtime error which may not be desired.