Skip to content

fix(qudarap): prevent call to undefined by guarding with a macro #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
plexoos wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(qudarap): prevent call to undefined by guarding with a macro #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions qudarap/QEvt.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1360,7 +1360,9 @@ NP* QEvt::gatherComponent_(unsigned cmp) const
switch(cmp)
{
//case SCOMP_GENSTEP: a = getGenstep() ; break ;
#ifndef PRODUCTION
case SCOMP_GENSTEP: a = gatherGenstepFromDevice() ; break ;
Comment on lines 1362 to 1364
Copy link

Copilot AI Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When PRODUCTION is defined, the SCOMP_GENSTEP case will return nullptr instead of providing the host-side genstep data. Consider uncommenting line 1362 to use getGenstep() as a fallback, or add an #else clause:

#ifndef PRODUCTION
        case SCOMP_GENSTEP:       a = gatherGenstepFromDevice() ; break ;
#else
        case SCOMP_GENSTEP:       a = getGenstep() ; break ;
#endif

This would ensure that genstep data remains accessible in production builds via the host-side copy, while avoiding the debug-only device download.

Suggested change
//case SCOMP_GENSTEP: a = getGenstep() ; break ;
#ifndef PRODUCTION
case SCOMP_GENSTEP: a = gatherGenstepFromDevice() ; break ;
#ifndef PRODUCTION
case SCOMP_GENSTEP: a = gatherGenstepFromDevice() ; break ;
#else
case SCOMP_GENSTEP: a = getGenstep() ; break ;

Copilot uses AI. Check for mistakes.
#endif
case SCOMP_INPHOTON: a = getInputPhoton() ; break ;
case SCOMP_PHOTON: a = gatherPhoton() ; break ;
case SCOMP_PHOTONLITE: a = gatherPhotonLite() ; break ;
Expand Down