feat: Improve plugin dependency requirements

e2e/nx-firebase-e2e/tests/test-workspace.spec.ts

@@ -43,7 +43,7 @@ describe('workspace setup', () => {
     expect(packageJson.dependencies['firebase-functions']).toBeDefined()
     expect(
       packageJson.devDependencies['firebase-functions-test'],
-    ).toBeDefined()
+    ).toBeUndefined()
 
     // check that plugin init generator adds @google-cloud/functions-framework if pnpm is being used
     // Use tmpProjPath() to detect the package manager in the e2e workspace, not the main project

packages/nx-firebase/src/generators/function/function.ts

@@ -9,7 +9,6 @@ import {
 } from '@nx/devkit'
 import { applicationGenerator as nodeApplicationGenerator } from '@nx/node'
 
-import { initGenerator } from '../init/init'
 import { getFirebaseConfigFromProject, updateTsConfig } from '../../utils'
 
 import { addFunctionConfig, createFiles, updateProject } from './lib'
@@ -104,10 +103,6 @@ export async function functionGenerator(
 
   // const options = normalizeOptions(host, schema)
 
-  // initialise plugin
-  const initTask = await initGenerator(host, {})
-  tasks.push(initTask)
-
   // We use @nx/node:app to scaffold our function application, then modify as required
   // `nx g @nx/node:app function-name --directory functions/dir --e2eTestRunner=none --framework=none --unitTestRunner=jest --bundler=esbuild --tags=firebase:firebase-app`
 

packages/nx-firebase/src/generators/init/init.spec.ts

@@ -80,9 +80,6 @@ describe('init generator', () => {
       `^${packageVersions.firebaseFunctions}`,
     )
 
-    expect(packageJson.devDependencies['firebase-functions-test']).toBe(
-      `^${packageVersions.firebaseFunctionsTest}`,
-    )
     expect(packageJson.devDependencies['firebase-tools']).toBe(
       `^${packageVersions.firebaseTools}`,
     )
@@ -115,7 +112,6 @@ describe('init generator', () => {
 
     packageJsonDefault.devDependencies['firebase-tools'] = testVersion
     packageJsonDefault.devDependencies['kill-port'] = testVersion
-    packageJsonDefault.devDependencies['firebase-functions-test'] = testVersion
 
     devkit.writeJson(tree, 'package.json', packageJsonDefault)
 
@@ -126,9 +122,6 @@ describe('init generator', () => {
     expect(packageJson.dependencies['firebase']).toBe(testVersion)
     expect(packageJson.dependencies['firebase-admin']).toBe(testVersion)
     expect(packageJson.dependencies['firebase-functions']).toBe(testVersion)
-    expect(packageJson.devDependencies['firebase-functions-test']).toBe(
-      testVersion,
-    )
     expect(packageJson.devDependencies['firebase-tools']).toBe(testVersion)
     expect(packageJson.devDependencies['kill-port']).toBe(testVersion)
 

packages/nx-firebase/src/generators/init/lib/add-dependencies.ts

@@ -74,10 +74,6 @@ export function addDependencies(tree: Tree): GeneratorCallback {
     'firebase-tools',
     `^${packageVersions.firebaseTools}`,
   )
-  addDevDependencyIfNotPresent(
-    'firebase-functions-test',
-    `^${packageVersions.firebaseFunctionsTest}`,
-  )
 
   // kill-port is used by the emulate target to ensure clean emulator startup
   // since Nx doesn't kill processes cleanly atm

packages/nx-firebase/src/generators/sync/sync.ts

@@ -4,15 +4,13 @@ import {
   joinPathFragments,
   logger,
   readProjectConfiguration,
-  runTasksInSerial,
   Tree,
   updateProjectConfiguration,
   writeJson,
 } from '@nx/devkit'
 
 import { SyncGeneratorSchema } from './schema'
 import { setFirebaseConfigFromCommand } from '../../utils'
-import initGenerator from '../init/init'
 
 import {
   debugInfo,
@@ -35,13 +33,7 @@ export async function syncGenerator(
   tree: Tree,
   options: SyncGeneratorSchema,
 ): Promise<GeneratorCallback> {
-  const tasks: GeneratorCallback[] = []
-
-  // initialise plugin
-  const initTask = await initGenerator(tree, {})
-  tasks.push(initTask)
-
-  // otherwise, sync the workspace.
+  // sync the workspace.
   // build lists of firebase apps & functions that have been deleted or renamed
   debugInfo('- Syncing workspace')
 
@@ -407,7 +399,9 @@ export async function syncGenerator(
     )
   }
 
-  return runTasksInSerial(...tasks)
+  return () => {
+    // noop - no install tasks needed
+  }
 }
 
 export default syncGenerator

tools/generate-package-versions.js

@@ -63,7 +63,6 @@ export const packageVersions = {
   firebase: '${packageJson.devDependencies['firebase']}',
   firebaseAdmin: '${packageJson.devDependencies['firebase-admin']}',
   firebaseFunctions: '${packageJson.devDependencies['firebase-functions']}',
-  firebaseFunctionsTest: '${packageJson.devDependencies['firebase-functions-test']}',
   firebaseTools: '${packageJson.devDependencies['firebase-tools']}',
   killPort: '${packageJson.devDependencies['kill-port']}',
   nodeEngine: '${nodeVersion}',