Enable parallel uploads #165
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Ok, so this will take longer to review - that needs a weekend and the next one is not possible |
Contributor
Author
|
No problem. Let me know when you have the time if there is any comments! |
Contributor
|
I would suggest adding tests here, so the code could also be checked with some examples. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recover the old parallelUploads param.
This param enables the parallel upload of files. The default value is 1, so the default behaviour is not changed.
To enable this, I needed to create all the folder structure beforehand, so then it can upload a unique list of files in
makeAndUpload.Maybe it would be interesting to add some event in the folder creation.
That is the only change to the default behaviour, I've tried to stay consistent with how files were handled and avoided changing any funcionality other than the already discussed.
Any comments are welcome!