Skip to content

Conversation

@shekharkhedekar
Copy link

Overview

Adds typescript and converts all js files to ts files.

This adds a build step, see package.json for details.

Verification

  • Made sure the tsc build passed and tests passed
  • npm link into a sample app to verify functionality

Future Work

  • Clean up all instances of as casting. This was mostly done because this.ftp could either be PromiseFtp or PromiseSftp, and those types do not play well with each other. The code is functionally the same, but the typescript could be cleaned up in this area.

@shekharkhedekar
Copy link
Author

@simonh1000 took another fresh pass on this with a priority to minimizing any changes to the library. Instead, I just focused on converting to TS. LMK what you think

@cyrdam
Copy link
Contributor

cyrdam commented Jan 17, 2024

this.ftp could either be PromiseFtp or PromiseSftp

As long as there is a test case for both and the result is the same it should be fine to use the as.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants