Open
Conversation
| # This will have errors for multiple text sections as objdump (at least 2.38) doesn't emit | ||
| # the correct labels for sections that are not the first | ||
|
|
||
| jump_table_targets: List[str] = [] # target_label |
Collaborator
Author
There was a problem hiding this comment.
Looks like it. I have the targets stored to it but they are never read from it.
Owner
|
(Should [WIP] be removed from the title?) |
Co-authored-by: Simon Lindholm <simon.lindholm10@gmail.com>
Co-authored-by: Simon Lindholm <simon.lindholm10@gmail.com>
Co-authored-by: Simon Lindholm <simon.lindholm10@gmail.com>
Co-authored-by: Simon Lindholm <simon.lindholm10@gmail.com>
1superchip
changed the title
Co-authored-by: Simon Lindholm <simon.lindholm10@gmail.com>
Co-authored-by: Simon Lindholm <simon.lindholm10@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a draft pr that implements handling of MSVC jumptables for x86. It currently requires diff function symbols to work properly as that is needed for the labels to be processed but it should not require that in the long run.
A small issue with this is that if there are multiple text sections, arrows will be shown in each text section. There was also an issue with objdump not emitting proper information for jumptables in a 2nd text section if the first section had a jump table.
objdump output of the jumptable:
objdump output of the assembly that is referenced from the jumptable:
An image of the final result:
We need <$Lnum> in the 2nd image to get the location.