Conversation
Owner
|
I went to add a test for the described behaviour but it's passing in the old version, before your PR changes. Shouldn't this code fail to assemble? |
Contributor
Author
|
Strange, i got an error with that sort of thing, however i did have a fix for another issue as well at the time, cant recall exactly the repro but it would define Struct1 and Struct2 with the address of PC when it found them which it shouldnt have done. (The Struct1 and Struct2 should never have been marked as symbols on their own) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed issue with structures defining symbols without prefix as well meaning two structures could not contain the same name element