Install sodetlib in the pysmurf_controller docker. #858
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrianJKoopman
requested changes
Apr 14, 2025
Member
BrianJKoopman
left a comment
BrianJKoopman
left a comment
There was a problem hiding this comment.
This looks fine to me, however it's based on a quite old commit. Can you rebase on the latest main?
tristpinsm
force-pushed
the
tpm/sodet-docker
branch
from
9b13b67 to
c5bc500
Compare
Contributor
Author
Done. Sorry I guess I had forgotten to pull |
tristpinsm
force-pushed
the
tpm/sodet-docker
branch
from
c5bc500 to
a2d76a5
Compare
BrianJKoopman
requested changes
Apr 16, 2025
Member
BrianJKoopman
left a comment
BrianJKoopman
left a comment
There was a problem hiding this comment.
Thanks for the rebase, found another issue with the sodetlib version, see inline comment.
tristpinsm
force-pushed
the
tpm/sodet-docker
branch
from
a2d76a5 to
faa54b0
Compare
BrianJKoopman
approved these changes
Apr 21, 2025
Member
BrianJKoopman
left a comment
BrianJKoopman
left a comment
There was a problem hiding this comment.
Looks good now, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Install
sodetlibin thepysmurf-controllerdocker image and bypass thesodetlibdocker image.Motivation and Context
Remove the
sodetlibdocker to simplify the docker inheritance hierarchy. Corresponding PR onsodetllib: simonsobs/sodetlib#460.How Has This Been Tested?
Built the docker image with these changes.
Types of changes
Checklist: