Skip to content

Conversation

@BrianJKoopman
Copy link
Member

Description

This adds a few missing parameters to the SMuRF File Emulator which have been added to the pysmurf-controller agent since this was last updated. We accept the parameters, but don't do anything with them. This may not be totally valid, but it at least lets me run a schedule without error to test functionality unrelated to the actual emulated data.

Motivation and Context

I was trying to test error handling in sorunlib and was running copies of real schedules run at site and needed these parameters added to do that.

How Has This Been Tested?

A copy of a real schedule was run on a local instance with two SMuRF File Emulators and an ACU simulator, as described in simonsobs/sorunlib#232.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@BrianJKoopman BrianJKoopman merged commit b7295af into main Sep 10, 2025
5 checks passed
@BrianJKoopman BrianJKoopman deleted the koopman/smurf-file-emulator-kwargs branch September 10, 2025 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants