EthicalAds uses adaptive color scheme #580
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed that the blog started using an adaptive color scheme, but the ads looked off in dark mode. The ad client supports an adaptive color scheme: https://ethical-ad-client.readthedocs.io/en/latest/#adaptive-color-scheme. This will work correctly in dark, light and auto mode. However, it required a small change to work in auto mode. To detect that the site uses an adaptive color scheme in auto mode, it needs to set `data-theme=auto`. Instead, your blog was removing `data-theme` when in auto mode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the blog started using an adaptive color scheme, but the ads looked off in dark mode. The ad client supports an adaptive color scheme:
https://ethical-ad-client.readthedocs.io/en/latest/#adaptive-color-scheme.
This will work correctly in dark, light and auto mode. However, it required a small change to work in auto mode. To detect that the site uses an adaptive color scheme in auto mode, it needs to set
data-theme=auto. Instead, your blog was removingdata-themewhen in auto mode. This change makes the site setdata-theme=autoand the CSS will look for that or fallback todata-themebeing unset which is what users with JS disabled will get.