feat: allow extra client metadata fields in DCR registration#110
Merged
feat: allow extra client metadata fields in DCR registration#110
Conversation
…108) Add support for optional OIDC client metadata fields (client_name, client_uri, logo_uri, tos_uri, policy_uri, contacts) in ClientMetadata and OAuthProvider. These fields are sent during dynamic client registration and parsed from the server response. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #108
Allows passing additional OIDC client metadata fields when constructing an
OAuthProvider. These fields are included in the Dynamic Client Registration request and are typically displayed to users on the authorization consent page.Changes
OAuthProviderclient_metadata:keyword arg toinitialize(default:{}). Accepted fields:client_name,client_uri,logo_uri,tos_uri,policy_uri,contacts.register_clientmerges extra metadata into the registration request.ClientMetadataclient_name,client_uri,logo_uri,tos_uri,policy_uri,contacts.to_hincludes them when set (omits nils via.compact).from_hparses them correctly.Usage
Tests
client_metadatakwarg is stored and accessibleClientMetadata#to_hincludes extra fields when set, omits them when nilClientMetadata.from_hparses extra fields correctlyBranch: feature/client-metadata-fields
URL: https://github.com/simonx1/ruby-mcp-client/pull/new/feature/client-metadata-fields