Java02. ДЗ 01, Старкова Анастасия, подгруппа 2#1
Open
simpledumpling wants to merge 3 commits intomasterfrom
Open
Java02. ДЗ 01, Старкова Анастасия, подгруппа 2#1simpledumpling wants to merge 3 commits intomasterfrom
simpledumpling wants to merge 3 commits intomasterfrom
Conversation
|
|
||
| private static class LockFreeLazy<T> implements Lazy<T> { | ||
| private volatile T result; | ||
| private volatile Supplier<T> mySupplier; |
There was a problem hiding this comment.
Либо используем префикс my, либо нет, но только что-то одно )
Owner
Author
|
@sproshev, исправила :) |
|
|
||
| public interface FactoryFromSupplier { | ||
| <T> Lazy<T> createLazy(Supplier<T> supplier); | ||
| } |
There was a problem hiding this comment.
Используется только в тестах, значит только там и должен жить )
|
зачтено, если бы замечания были исправлены, было бы 10, иначе -- только половина ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@sproshev