-
Notifications
You must be signed in to change notification settings - Fork 0
chore(ci): Update Go to 1.25 and upgrade golangci-lint #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This commit updates the GitHub Actions CI workflow to add support for the upcoming Go 1.25 release and upgrades the linting tools. The build and test jobs now run against Go versions 1.24 and 1.25, dropping support for the older Go 1.22. This aligns with the standard practice of supporting the two latest major Go releases, ensuring the project remains compatible with the current language toolchain. Additionally, the `golangci-lint` job is updated: - The Go version for the lint job is set to 1.25. - The `golangci/golangci-lint-action` is upgraded from v2.1.6 to v2.5.0 to leverage the latest linters, performance improvements, and bug fixes.
Summary of ChangesHello @FranciscoKurpiel, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request modernizes the project's continuous integration setup by integrating support for the upcoming Go 1.25 release and upgrading the Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request aims to update the Go version to 1.25 and upgrade golangci-lint. While the change in go.mod reflects the Go version bump, it's set to 1.25. According to the PR description, the project is intended to be tested against Go 1.24 and 1.25. Setting the module version to 1.25 will cause build failures on Go 1.24. I've suggested updating the go.mod to go 1.24 to maintain compatibility. Please note that the PR description mentions changes to the CI workflow files, but these were not included in the provided patch for review.
This commit updates the GitHub Actions CI workflow to add support for Go 1.25 release and upgrades the linting tools.
The build and test jobs now run against Go versions 1.24 and 1.25, dropping support for the older Go 1.22. This aligns with the standard practice of supporting the two latest major Go releases, ensuring the project remains compatible with the current language toolchain.
Additionally, the
golangci-lintjob is updated:golangci/golangci-lint-actionis upgraded from v2.1.6 to v2.5.0 to leverage the latest linters, performance improvements, and bug fixes.