Skip to content

Conversation

@FranciscoKurpiel
Copy link
Collaborator

@FranciscoKurpiel FranciscoKurpiel commented Oct 22, 2025

This commit updates the GitHub Actions CI workflow to add support for Go 1.25 release and upgrades the linting tools.

The build and test jobs now run against Go versions 1.24 and 1.25, dropping support for the older Go 1.22. This aligns with the standard practice of supporting the two latest major Go releases, ensuring the project remains compatible with the current language toolchain.

Additionally, the golangci-lint job is updated:

  • The Go version for the lint job is set to 1.25.
  • The golangci/golangci-lint-action is upgraded from v2.1.6 to v2.5.0 to leverage the latest linters, performance improvements, and bug fixes.

This commit updates the GitHub Actions CI workflow to add support for the
upcoming Go 1.25 release and upgrades the linting tools.

The build and test jobs now run against Go versions 1.24 and 1.25, dropping
support for the older Go 1.22. This aligns with the standard practice of
supporting the two latest major Go releases, ensuring the project remains
compatible with the current language toolchain.

Additionally, the `golangci-lint` job is updated:
- The Go version for the lint job is set to 1.25.
- The `golangci/golangci-lint-action` is upgraded from v2.1.6 to v2.5.0
  to leverage the latest linters, performance improvements, and bug fixes.
@FranciscoKurpiel FranciscoKurpiel self-assigned this Oct 22, 2025
@FranciscoKurpiel FranciscoKurpiel added CI/CD dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code labels Oct 22, 2025
@gemini-code-assist
Copy link

Summary of Changes

Hello @FranciscoKurpiel, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request modernizes the project's continuous integration setup by integrating support for the upcoming Go 1.25 release and upgrading the golangci-lint tool. These changes ensure the project remains current with the Go ecosystem, benefits from the latest language features and performance enhancements, and maintains robust code quality through updated linting capabilities.

Highlights

  • Go Version Update: The CI workflow has been updated to support the upcoming Go 1.25 release, aligning with the standard practice of supporting the two latest major Go versions. This change also includes support for Go 1.24 and drops support for the older Go 1.22.
  • Linting Tool Upgrade: The golangci-lint action has been upgraded from v2.1.6 to v2.5.0, and the lint job is now configured to run with Go 1.25. This upgrade brings the latest linters, performance improvements, and bug fixes.
Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/ci.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to update the Go version to 1.25 and upgrade golangci-lint. While the change in go.mod reflects the Go version bump, it's set to 1.25. According to the PR description, the project is intended to be tested against Go 1.24 and 1.25. Setting the module version to 1.25 will cause build failures on Go 1.24. I've suggested updating the go.mod to go 1.24 to maintain compatibility. Please note that the PR description mentions changes to the CI workflow files, but these were not included in the provided patch for review.

@FranciscoKurpiel FranciscoKurpiel merged commit 7b948f9 into master Oct 22, 2025
5 checks passed
@FranciscoKurpiel FranciscoKurpiel deleted the go-1.25-golangcilint-2.5.0 branch October 22, 2025 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI/CD dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code

Development

Successfully merging this pull request may close these issues.

2 participants