Open
Conversation
toloudis
reviewed
Oct 11, 2024
| // When should it be set, if ever; what should it be used for, if anything? | ||
| public cancelled = false; | ||
| private image?: VolumeDrawable; | ||
| private drawable?: VolumeDrawable; |
Contributor
There was a problem hiding this comment.
If I recall, I think the "cancelled" property mentioned above is for when the trajectory has been changed but there is still geometry download requests in-flight. We can use cancelled to just drop the arriving stuff.
…ium/simularium-viewer into feature/volume-rendering
frasercl
requested review from
meganrm and
tyler-foster
and removed request for
a team
Bumps [http-proxy-middleware](https://github.com/chimurai/http-proxy-middleware) from 2.0.7 to 2.0.9. - [Release notes](https://github.com/chimurai/http-proxy-middleware/releases) - [Changelog](https://github.com/chimurai/http-proxy-middleware/blob/v2.0.9/CHANGELOG.md) - [Commits](chimurai/http-proxy-middleware@v2.0.7...v2.0.9) --- updated-dependencies: - dependency-name: http-proxy-middleware dependency-version: 2.0.9 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 5.4.17 to 5.4.18. - [Release notes](https://github.com/vitejs/vite/releases) - [Changelog](https://github.com/vitejs/vite/blob/v5.4.18/packages/vite/CHANGELOG.md) - [Commits](https://github.com/vitejs/vite/commits/v5.4.18/packages/vite) --- updated-dependencies: - dependency-name: vite dependency-version: 5.4.18 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 6.2.5 to 6.3.4. - [Release notes](https://github.com/vitejs/vite/releases) - [Changelog](https://github.com/vitejs/vite/blob/main/packages/vite/CHANGELOG.md) - [Commits](https://github.com/vitejs/vite/commits/v6.3.4/packages/vite) --- updated-dependencies: - dependency-name: vite dependency-version: 6.3.4 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
* fix URL with two back slashes * move URL into helper function with comment
…les/http-proxy-middleware-2.0.9 Bump http-proxy-middleware from 2.0.7 to 2.0.9 in /examples
…5.4.18 Bump vite from 5.4.17 to 5.4.18
…les/vite-6.3.4 Bump vite from 6.2.5 to 6.3.4 in /examples
Bumps [webpack-dev-server](https://github.com/webpack/webpack-dev-server) from 5.1.0 to 5.2.1. - [Release notes](https://github.com/webpack/webpack-dev-server/releases) - [Changelog](https://github.com/webpack/webpack-dev-server/blob/master/CHANGELOG.md) - [Commits](webpack/webpack-dev-server@v5.1.0...v5.2.1) --- updated-dependencies: - dependency-name: webpack-dev-server dependency-version: 5.2.1 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
…les/webpack-dev-server-5.2.1 Bump webpack-dev-server from 5.1.0 to 5.2.1 in /examples
Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 5.4.18 to 5.4.19. - [Release notes](https://github.com/vitejs/vite/releases) - [Changelog](https://github.com/vitejs/vite/blob/v5.4.19/packages/vite/CHANGELOG.md) - [Commits](https://github.com/vitejs/vite/commits/v5.4.19/packages/vite) --- updated-dependencies: - dependency-name: vite dependency-version: 5.4.19 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
…5.4.19 Bump vite from 5.4.18 to 5.4.19
Bumps [on-headers](https://github.com/jshttp/on-headers) and [compression](https://github.com/expressjs/compression). These dependencies needed to be updated together. Updates `on-headers` from 1.0.2 to 1.1.0 - [Release notes](https://github.com/jshttp/on-headers/releases) - [Changelog](https://github.com/jshttp/on-headers/blob/master/HISTORY.md) - [Commits](jshttp/on-headers@v1.0.2...v1.1.0) Updates `compression` from 1.7.5 to 1.8.1 - [Release notes](https://github.com/expressjs/compression/releases) - [Changelog](https://github.com/expressjs/compression/blob/master/HISTORY.md) - [Commits](expressjs/compression@1.7.5...v1.8.1) --- updated-dependencies: - dependency-name: on-headers dependency-version: 1.1.0 dependency-type: indirect - dependency-name: compression dependency-version: 1.8.1 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
…les/multi-96c788614a Bump on-headers and compression in /examples
--- updated-dependencies: - dependency-name: form-data dependency-version: 4.0.4 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
…data-4.0.4 Bump form-data from 4.0.1 to 4.0.4
Contributor
|
Is stale, needs merge from main but also updates to volE core need to be re-merged and tested. It's ok if we put this on hold for a while. |
* add export field to package.json * import stylesheet index.ts * move stylesheet import up one level * don't procses css in vitest * take style directory out of copy-build step * remove top level stylesheet duplication restore exports field
# Conflicts: # src/visGeometry/GeometryStore.ts
Contributor
|
VolumeLoadWorker from vole-core is not being loaded when using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review size: medium (20-25min)
Resolves #406: makes volume agents render properly!
Adds some new semantics for volume agent data: if the agent has subpoints, subpoint 0 represents the time point of the volume to load and display, and the rest are indexes of channels to enable. By default, if no subpoints are included, timepoint 0 is loaded and only channel 0 is enabled.
Note that this change is accompanied by changes on the companion branch in volume-viewer,
simularium-volumes. As with the previous PR in this series (#417), this branch doesn't work without the changes on that branch. (allen-cell-animated/vole-core#255 will merge those changes into the viewer proper, after which we'll be able to use a plain old npm dependency and get tests to pass here.)Note also that I've hardcoded values for more than a few volume render settings. We may still have more semantics to figure out around whether to pick sensible defaults for these settings, or whether to add some new settings to the subpoints schema described above.
Screenshot