Skip to content

Code review #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Andarix wants to merge 222 commits into
base: main
Choose a base branch
from
Open

Code review #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
222 commits
Select commit Hold shift + click to select a range
3e4e14a
CHG set depot tile
Andarix Jan 7, 2025
e010a0b
FIX build road
Andarix Jan 8, 2025
feb1c6b
FIX passanger count
Andarix Jan 8, 2025
0d1ee72
FIX build depot road
Andarix Jan 8, 2025
b3d6a2d
CHG city limit and coords building chapter 1
Andarix Jan 8, 2025
807e384
ADD file for messages
Andarix Jan 8, 2025
f42219c
CHG Separation of code and coords/text
Andarix Jan 8, 2025
594fc1d
CHG Separation of code and coords/text
Andarix Jan 8, 2025
4b11448
CHG set depot coord
Andarix Jan 8, 2025
6a5e165
CHG bus stops ch2 stC
Andarix Jan 8, 2025
bb1a39d
CHG textfile
Andarix Jan 8, 2025
37b3c8a
CHG comment
Andarix Jan 8, 2025
c4d2e38
FIX errors
Andarix Jan 8, 2025
0dbe528
CHG update translate files
Andarix Jan 9, 2025
7625d9e
CHG ch2 steps
Andarix Jan 9, 2025
1101cac
CHG code review chapter 2
Andarix Jan 9, 2025
6e46775
FIX missing code
Andarix Jan 9, 2025
427d8d2
FIX check build bridge
Andarix Jan 9, 2025
12872bd
FIX Bug building the dead end street for the depot
Yona-TYT Jan 9, 2025
1181dcf
FIX some coord in pak64
Yona-TYT Jan 9, 2025
c89e7cf
Merge remote-tracking branch 'remotes/origin/code_review' into code_r…
Andarix Jan 10, 2025
076b7ae
CHG remove c_lock
Andarix Jan 10, 2025
adf9431
FIX missing parameter
Andarix Jan 10, 2025
43b7d86
CHG remove c_lock
Andarix Jan 10, 2025
d6fa253
CHG line names for automated build
Andarix Jan 10, 2025
09c6acb
CHG chapter count for if
Andarix Jan 10, 2025
7ebd3eb
merge changes Yona
Andarix Jan 10, 2025
3dc90b9
CHG name from lines by automatic build
Andarix Jan 11, 2025
b54dd27
CHG last step in last chapter return 100%
Andarix Jan 11, 2025
4ca56ad
FIX wrong line set chapter 6 step 3
Andarix Jan 11, 2025
8af2a7b
CHG coords move to separate file
Andarix Jan 11, 2025
b06f77c
CHG chapter 7 - no specific field at the station for the bus stop
Andarix Jan 11, 2025
e68ad51
CHG update translate files
Andarix Jan 12, 2025
78a402e
CHG change code for rail line forrest saw mill
Andarix Jan 12, 2025
e100364
FIX build stations
Andarix Jan 12, 2025
15ccc49
Fix coord in CH3 depot
Yona-TYT Jan 13, 2025
295b699
Fix coord in CH3 depot (commad auto script)
Yona-TYT Jan 13, 2025
cb1af9c
ADD astar classes from Dwachs sqai
Andarix Jan 13, 2025
7fe6372
Merge commit '15ccc49ed7d308f9f622beb4d7d115602b2dca08' into code_review
Andarix Jan 13, 2025
0a3e7e0
Merge remote-tracking branch 'remotes/origin/code_review' into code_r…
Andarix Jan 13, 2025
4673b20
CHG ch3 rail line 1 coords to seperate file
Andarix Jan 23, 2025
a9dd4fb
CHG ch3 rail line 2 coords to seperate file
Andarix Jan 23, 2025
807290a
CHG chapter 3 step H - build city 1 to city 2
Andarix May 3, 2025
1bf270f
CHG finish chapter 3
Andarix May 4, 2025
5cda1f9
CHG set coords
Andarix May 9, 2025
94c2c22
Fix bridges in CH 3
Yona-TYT May 10, 2025
be4311c
FIX errors
Andarix May 10, 2025
095f12d
FIX errors
Andarix May 11, 2025
7fbf0a6
Fix texts files in CH2
Yona-TYT May 11, 2025
5f75194
Texts moves (Follow convoy) to step 7
Yona-TYT May 15, 2025
0aba71f
CHG code (Follow convoy) to step 7
Yona-TYT May 15, 2025
d6e0b8f
Remove cov_sw var
Yona-TYT May 17, 2025
77ac153
Add coord for current convoy CH2
Yona-TYT May 17, 2025
da8d250
Fix minor bug
Yona-TYT May 17, 2025
9b32105
Remov debug message
Yona-TYT May 17, 2025
73f960d
Minor fix, Prissi: Clean up of schedule code and working with other t…
Yona-TYT May 21, 2025
ff7f7f2
CHG chapter 4
Andarix May 23, 2025
b84a05f
CHG chapter 5
Andarix May 26, 2025
02c9339
CHG auto find tiles for transformer
Andarix May 27, 2025
df3d5fa
CHG fix errors and set pakset coords
Andarix May 27, 2025
a984951
CHG Progress
Andarix May 27, 2025
6c6bf7b
CHG chapter 5 data
Andarix May 28, 2025
472ed8f
FIX chapter 2 step 6 1/2 text file output (new textfile download)
Andarix May 28, 2025
3465601
FIX text errors
Andarix May 28, 2025
98a06b0
CHG update translate files
Andarix May 28, 2025
6afdd94
CHG way test function
Andarix May 28, 2025
4ae5354
CHG text output
Andarix May 28, 2025
31c5ce8
CHG text output
Andarix May 28, 2025
f04cac0
CHG check halt accept mail befor build mail extension
Andarix May 28, 2025
b1e0895
CHG translate files
Andarix May 28, 2025
0a9b8ea
CHG remove unused text files
Andarix May 28, 2025
6bd831f
CHG error message and not check build extension by accept mail
Andarix May 29, 2025
45fe110
CHG better messages
Andarix May 29, 2025
80712ea
CHG translate files
Andarix May 29, 2025
dd3fc8e
CHG vehicle pak64.german
Andarix May 29, 2025
1e3c123
CHG update translate files
Andarix May 29, 2025
9fe7e54
Initial work: Text labels without owners (class basic chapter)
Yona-TYT Jun 22, 2025
ab345a2
CHG Text labels without owners
Yona-TYT Jun 22, 2025
378e805
FIX rotate error by factorys
Andarix Jun 26, 2025
ba8b91a
Merge branch 'code_review' of https://github.com/simutrans/tutorial_m…
Andarix Jun 26, 2025
34515cd
CHG disabled debug messages
Andarix Jun 26, 2025
aa7e0eb
CHG better code
Andarix Jun 26, 2025
4d5f8ef
Fix Text labels in electrified rails
Yona-TYT Jun 27, 2025
237b29b
FIX missing parameter
Andarix Jun 27, 2025
44a5561
CHG rename funktion better name
Andarix Jun 27, 2025
f952f04
CHG move function search_tile_in_tiles() to class_basic_chapter.nut
Andarix Jun 27, 2025
e0e8b59
Fix error with undefined search_tile_in_tiles()
Yona-TYT Jul 1, 2025
3b4e74f
Fix error with undefined var
Yona-TYT Jul 1, 2025
ad8b251
FIX missing variables
Andarix Jul 3, 2025
7d5eca6
Fix inconsistent layer values
Yona-TYT Jul 24, 2025
1288534
Fix Syntax error
Yona-TYT Jul 24, 2025
90de54c
FIX tunnel coord
Andarix Jul 24, 2025
468c5b3
CHG chapter 7 all slope tools allowed
Andarix Jan 2, 2026
812f9ed
FIX schedule error chapter 2 step F
Andarix Jan 2, 2026
d4c3d02
CHG check finish step befor automatic jump to next step
Andarix Jan 3, 2026
338587f
UPD translate file
Andarix Jan 3, 2026
c9c54db
FIX schedule error not water schedule allowed
Andarix Jan 3, 2026
4d819fa
FIX error by bridge build automatic step
Andarix Jan 3, 2026
30c9319
FIX schedule errors chapter 5
Andarix Jan 3, 2026
f6c53d0
FIX waytype ba schedule check
Andarix Jan 3, 2026
15b7ce1
FIX wrong message
Andarix Jan 3, 2026
5841333
FIX airplane schedule and start
Andarix Jan 3, 2026
34e076f
FIX show schedule list
Andarix Jan 4, 2026
236d58f
CHG set version to 2.0.02
Andarix Jan 4, 2026
f39b5b2
CHG text chapter 3 step E - factory names to stations names
Andarix Jan 5, 2026
b3add0b
CHG station names for clickable links
Andarix Jan 5, 2026
bdfd1c7
CHG CHG text chapter 3 step G - factory names to stations names
Andarix Jan 5, 2026
4e69695
CHG disabled debug message
Andarix Jan 5, 2026
dff30d9
CHG unnecessary code removed
Andarix Jan 6, 2026
99fac8b
FIX error bridge build by automatic step
Andarix Jan 6, 2026
99e69c8
CHG minor code optimization
Andarix Jan 6, 2026
28323e8
CHG unnecessary code removed
Andarix Jan 6, 2026
00610fb
FIX chapter 6 step A - build extensions building
Andarix Jan 6, 2026
7a0e255
CHG better tile for terminal
Andarix Jan 6, 2026
203cad5
CHG coords move to class_basic_coords
Andarix Jan 6, 2026
8b90608
FIX text output coord
Andarix Jan 7, 2026
cf2c754
CHG chapter 6 - move coords to class_basic_coords
Andarix Jan 7, 2026
77dc19b
CHG unnecessary code removed
Andarix Jan 7, 2026
ad00b08
CHG move convoy count to class_basic_data
Andarix Jan 7, 2026
741349a
FIX wrong parameter
Andarix Jan 7, 2026
00c296f
CHG coords move to class_basic_coords
Andarix Jan 8, 2026
b484d9c
CHG unnecessary code removed
Andarix Jan 8, 2026
d61f9a8
CHG chapter 4 step 7 - add oil rigg (factory 4) to schedule passenger…
Andarix Jan 8, 2026
f64f69c
CHG unnecessary code removed
Andarix Jan 8, 2026
1232f82
CHG version to 2.0.03
Andarix Jan 8, 2026
3d3da8f
FIX chapter 7 - count passenger
Andarix Jan 9, 2026
aa636c9
CHG remove debug message
Andarix Jan 9, 2026
2ef6762
CHG output scenario finish
Andarix Jan 9, 2026
0d4efe1
CHG textfiles
Andarix Jan 10, 2026
c22b4fa
ADD script download texts
Andarix Jan 10, 2026
66178d8
CHG schedules
Andarix Jan 10, 2026
7aed81c
CHG code style
Andarix Jan 10, 2026
cafc656
CHG add define waiting halts for passenger lines
Andarix Jan 10, 2026
8cbbd89
CHG comment
Andarix Jan 10, 2026
9d520aa
CHG code style
Andarix Jan 10, 2026
cfa4a8c
CHG add passenger waiting halts chapter 3 - 6
Andarix Jan 10, 2026
7417fe9
CHG configurable waiting halts for passenger lines
Andarix Jan 10, 2026
4e820c5
CHG changed text step 2/B and add configurable waiting halts for pass…
Andarix Jan 10, 2026
b7f6867
FIX schedule edit
Andarix Jan 10, 2026
784bccb
CHG add get_waiting_halt code
Andarix Jan 10, 2026
2529999
FIX typo
Andarix Jan 10, 2026
1014074
FIX set OK for add halt to schedule
Andarix Jan 10, 2026
dd952c0
CHG add translate text for link to next step
Andarix Jan 11, 2026
0ac6793
ADD menu icons to text
Andarix Jan 11, 2026
b1b997f
ADD info files for img tags in texts
Andarix Jan 11, 2026
b338cc5
FIX typo
Andarix Jan 11, 2026
fcf9a86
CHG grid icon from main menu, not from settings
Andarix Jan 11, 2026
7ebc3a1
FIX chapter 6 text
Andarix Jan 13, 2026
0a972e4
CHG disabled debug message
Andarix Jan 13, 2026
2794dec
CHG changed function check_halt_public() to search halt tile accordin…
Andarix Jan 13, 2026
c59bcfb
CHG clean up code
Andarix Jan 13, 2026
0ceb8eb
CHG chapter 2 to configurable waiting halts for passenger lines
Andarix Jan 14, 2026
64e89d9
CHG clean up and optimize text output
Andarix Jan 14, 2026
9eba974
CHG code comment
Andarix Jan 14, 2026
e3e85ba
ADD conv.set_followed() in commad script
Yona-TYT Jan 14, 2026
3945551
Merge pull request #42 from Yona-TYT/code_review
Andarix Jan 14, 2026
869340b
CHG chapter 6 airport tower to terminal
Andarix Jan 15, 2026
056583d
CHG code clean up
Andarix Jan 15, 2026
379d5ec
CHG version 2.0.04 - Simutrans >= r11871
Andarix Jan 15, 2026
2a071c2
CHG line settings pak64
Andarix Jan 15, 2026
cf5f8ec
CHG search empty tiles for post extension on halts
Andarix Jan 16, 2026
3790464
CHG comments
Andarix Jan 16, 2026
f109888
FIX schedule error step 4
Andarix Jan 16, 2026
aa369f4
ADD info closed scenario window
Andarix Jan 16, 2026
914f4c7
CHG chapter 5 step D - post extension review
Andarix Jan 20, 2026
82f049d
CHG clean up code; code style
Andarix Jan 20, 2026
67c37b6
CHG Functions removed with just one call
Andarix Jan 21, 2026
09d9d0c
CHG chapter 2 text - add tool icons
Andarix Jan 23, 2026
1ad06ab
FIX error siz missing
Andarix Jan 24, 2026
fedc0c3
CHG comments
Andarix Jan 24, 2026
1225b86
ADD settings.get_make_public_months()
Andarix Jan 25, 2026
8e5cc64
CHG remove price to make stop public; v2.0.06 require simutrans r11875
Andarix Jan 25, 2026
671bb79
CHG comments for documentation
Andarix Jan 26, 2026
90b7c47
CHG Selected stop to be tested for acceptance before construction beg…
Andarix Jan 27, 2026
25e4601
CHG code style
Andarix Jan 28, 2026
80ef203
ADD comments
Andarix Jan 28, 2026
bdd8398
CHG add check selected halt
Andarix Jan 28, 2026
3f45be8
FIX good check halt selected halt
Andarix Jan 28, 2026
4b62372
CHG comments
Andarix Jan 28, 2026
d5491df
CHG add check selected halt chapter 5
Andarix Jan 28, 2026
74c8ab7
CHG comments
Andarix Jan 28, 2026
9065d1f
CHG code style
Andarix Jan 28, 2026
d239656
CHG code style and remove obsolete code
Andarix Jan 28, 2026
8bc2d46
CHG def to auto select from depots, extension mail, powerline and canal
Andarix Jan 28, 2026
dcea073
CHG check selected tool runway and taxiway befor build
Andarix Jan 28, 2026
6043a1e
FIX coord output in error message
Andarix Jan 28, 2026
736725d
CHG update texts
Andarix Jan 28, 2026
fe2f1fd
FIX errors chapter 6
Andarix Jan 28, 2026
6ebc1c1
CHG comments
Andarix Jan 30, 2026
a3e64b7
CHG optimization Array definitions
Andarix Jan 30, 2026
1a420a8
CHG pot* to array pot[*]
Andarix Jan 30, 2026
42a2cb1
FIX depot search
Andarix Jan 30, 2026
8e8e51a
CHG clean up code
Andarix Jan 31, 2026
5376b1a
FIX autobuild canal
Andarix Feb 1, 2026
e8e34fa
FIX wrong parameter
Andarix Feb 1, 2026
da37550
FIX check click curisity
Andarix Feb 1, 2026
b2b8c76
CHG coords pak64.german
Andarix Feb 1, 2026
41d5d1e
CHG optimize code
Andarix Feb 1, 2026
5b5ce60
FIX typo
Andarix Feb 2, 2026
b452ce9
CHG clean up code
Andarix Feb 3, 2026
ab09a4e
CHG error message and move to class_messages.nut
Andarix Feb 3, 2026
28938cc
CHG error message and move to class_messages.nut
Andarix Feb 3, 2026
0be171c
CHG message move to class_messages.nut
Andarix Feb 3, 2026
3309484
CHG clean up code and change text messages
Andarix Feb 6, 2026
4de2b20
CHG version
Andarix Feb 7, 2026
598da5b
CHG clean up code and change text messages
Andarix Feb 7, 2026
d44469d
CHG clean up code and fix errors
Andarix Feb 8, 2026
ddfb8ac
CHG clean up code and change text messages
Andarix Feb 8, 2026
ec2c378
ADD inspections tool id
Andarix Feb 8, 2026
66547ac
CHG optimize code
Andarix Feb 8, 2026
6f0e88d
FIX tool bar icon pak64.german
Andarix Feb 8, 2026
b8bc6c3
FIX tool select with key
Andarix Feb 9, 2026
0c7f5b1
Fix red mark in rails CH3 ST D
Yona-TYT Feb 15, 2026
cda93ef
Fix red mark in rails CH3 ST G
Yona-TYT Feb 15, 2026
7a169a2
CHG way tool select with key (require Simutrans r11881)
Andarix Feb 16, 2026
3fe9598
CHG coord or coord3d
Andarix Feb 22, 2026
9a6bde0
CHG code style
Andarix Feb 22, 2026
3bb50a8
CHG test way check with astar (not work, disabled)
Andarix Feb 22, 2026
f9dee50
CHG zone limit
Andarix Feb 22, 2026
1b5ff4a
CHG add new parameter for way check with astar
Andarix Feb 22, 2026
78f2df3
CHG add code for way check with astar
Andarix Feb 22, 2026
907d778
FIX text coord
Andarix Feb 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,4 @@
*.kdev4
*.ods#
.~lock*
/docu
Loading