Fix false positives on high-resolution monitors#78
Open
divol89 wants to merge 1 commit intosindresorhus:mainfrom
Open
Fix false positives on high-resolution monitors#78divol89 wants to merge 1 commit intosindresorhus:mainfrom
divol89 wants to merge 1 commit intosindresorhus:mainfrom
Conversation
…ixes sindresorhus#33) Changes: - Increased threshold from 170 to 200 pixels - Added upper bound check (<600) to filter out unusual monitor configurations - Prevents false positives on 1920x1980 and similar vertical/portrait resolutions The previous threshold of 170 was causing false positives on monitors with unusual aspect ratios like 1920x1980. The new logic requires the dimension difference to be both greater than 200 AND less than 600, which better distinguishes actual DevTools panels from normal browser chrome on high-res displays. Fixes sindresorhus#33 Bounty: (IssueHunt)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #33
Reduces false positives on high-resolution and vertical monitors (like 1920x1980) by:
This ensures the detection works for actual DevTools while avoiding false positives on high-res displays.
Fixes IssueHunt bounty #33 ().