Skip to content

Fix install error handling #1456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
maxugly wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix install error handling #1456

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3b94d27
Fix regex pattern in get_release_url function
maxugly Apr 2, 2026
428d0c3
fix: add error handling and /tmp fallback to AppImage install
maxugly Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 35 additions & 20 deletions scripts/install.sh
100644 → 100755
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ install_arch() {
get_release_url() {
# $1 = pattern (e.g., .deb or .rpm)
# $2 = arch
url=$(curl -s "https://api.github.com/repos/${REPO_OWNER}/${REPO_NAME}/releases/latest" | grep "browser_download_url.*$2.*$1" | cut -d '"' -f 4 | head -n 1)
url=$(curl -s "https://api.github.com/repos/${REPO_OWNER}/${REPO_NAME}/releases/latest" | grep "browser_download_url.*$2.*${1%$}" | cut -d '"' -f 4 | head -n 1)
echo "$url"
}

Expand Down Expand Up @@ -169,19 +169,16 @@ install_fedora() {

do_install_appimage() {
log_info "Attempting AppImage install..."
if ! check_cmd curl; then log_error "curl is required."; fi
if ! check_cmd curl; then log_error "curl is required."; return 1; fi
Copy link
Copy Markdown
Owner

@sinelaw sinelaw Apr 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

log_error already exits, no need for return


ARCH=$(uname -m)
# Map architecture to AppImage naming
case "$ARCH" in
x86_64) APPIMAGE_ARCH="x86_64" ;;
aarch64) APPIMAGE_ARCH="aarch64" ;;
arm64) APPIMAGE_ARCH="aarch64" ;;
aarch64|arm64) APPIMAGE_ARCH="aarch64" ;;
*) log_warn "AppImage not available for architecture: $ARCH"; return 1 ;;
esac

URL=$(get_release_url "\.AppImage$" "$APPIMAGE_ARCH")

if [ -z "$URL" ]; then
log_warn "No AppImage found for $APPIMAGE_ARCH."
return 1
Expand All @@ -191,28 +188,46 @@ do_install_appimage() {
BIN_DIR="${HOME}/.local/bin"
SYMLINK_PATH="${BIN_DIR}/fresh"

# Download to temp file
TEMP_APPIMAGE=$(mktemp)
log_info "Downloading AppImage from $URL..."
curl -sL "$URL" -o "$TEMP_APPIMAGE"
# Create workspace with fallback if /tmp is restricted
BASE_TEMP=$(mktemp -d 2>/dev/null || echo "$HOME/.cache/fresh-work-$(date +%s)")
mkdir -p "$BASE_TEMP"

# Ensure cleanup on exit or interruption
trap 'rm -rf "$BASE_TEMP"' EXIT

TEMP_APPIMAGE="$BASE_TEMP/fresh.AppImage"
TEMP_EXTRACT="$BASE_TEMP/extract"
mkdir -p "$TEMP_EXTRACT"

log_info "Downloading AppImage..."
if ! curl -sL "$URL" -o "$TEMP_APPIMAGE"; then
log_error "Download failed."
return 1
fi
chmod +x "$TEMP_APPIMAGE"

# Extract AppImage (faster startup than running via FUSE)
log_info "Extracting AppImage..."
TEMP_EXTRACT=$(mktemp -d)
(cd "$TEMP_EXTRACT" && "$TEMP_APPIMAGE" --appimage-extract > /dev/null 2>&1)
rm -f "$TEMP_APPIMAGE"
if ! (cd "$TEMP_EXTRACT" && "$TEMP_APPIMAGE" --appimage-extract > /dev/null 2>&1); then
log_error "Extraction failed (Check disk space or binary compatibility)."
return 1
fi

# Remove old installation and move new one in place
rm -rf "$INSTALL_DIR"
# Verify extraction success before modifying host system
if [ ! -d "$TEMP_EXTRACT/squashfs-root" ]; then
log_error "Extraction completed but source files are missing."
return 1
fi

log_info "Finalizing installation..."
mkdir -p "$INSTALL_DIR" "$BIN_DIR"
Copy link
Copy Markdown
Owner

@sinelaw sinelaw Apr 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

INSTALL_DIR is immediately removed after being created here, can skip creation

mv "$TEMP_EXTRACT/squashfs-root"/* "$INSTALL_DIR/"
rm -rf "$TEMP_EXTRACT"

# Atomic update of the installation directory
rm -rf "$INSTALL_DIR"
Copy link
Copy Markdown
Owner

@sinelaw sinelaw Apr 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

potentially destroys user data? can we move to tmp dir instead?

mv "$TEMP_EXTRACT/squashfs-root" "$INSTALL_DIR" || { log_error "Failed to move files to $INSTALL_DIR"; return 1; }

# Create symlink to the binary
ln -sf "$INSTALL_DIR/usr/bin/fresh" "$SYMLINK_PATH"

# Check if ~/.local/bin is in PATH
# Verify PATH
case ":$PATH:" in
*":${BIN_DIR}:"*) ;;
*)
Expand Down