Skip to content

upgrade python version to 3.12#30

Open
akkumar-qlik wants to merge 9 commits intoSAC-30240-tap-codat-standardize-statefrom
SAC-28697-tap-codat-upgrade-python-version
Open

upgrade python version to 3.12#30
akkumar-qlik wants to merge 9 commits intoSAC-30240-tap-codat-standardize-statefrom
SAC-28697-tap-codat-upgrade-python-version

Conversation

@akkumar-qlik
Copy link
Copy Markdown

Description of change

(write a short description or paste a link to JIRA)

Manual QA steps

Risks

Rollback steps

  • revert this branch

AI generated code

https://internal.qlik.dev/general/ways-of-working/code-reviews/#guidelines-for-ai-generated-code

  • this PR has been written with the help of GitHub Copilot or another generative AI tool

@akkumar-qlik akkumar-qlik self-assigned this Mar 27, 2026
…nger-io/tap-codat into SAC-28697-tap-codat-upgrade-python-version
@akkumar-qlik akkumar-qlik changed the base branch from master to SAC-30240-tap-codat-standardize-state March 27, 2026 05:24
@akkumar-qlik akkumar-qlik requested a review from Copilot March 27, 2026 05:25
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the CI environment to run on Python 3.12 and adds a comprehensive new suite of unit + integration tests for the tap_codat tap (covering discovery, sync/state/bookmark behavior, HTTP client handling, and datetime transforms).

Changes:

  • Update CircleCI config to use Python 3.12 and run unit tests with coverage + separate integration tests.
  • Add extensive unittest-style unit tests under tests/unittests/ for core modules.
  • Add mock-based integration tests under tests/ (with shared tests/base.py) and remove an older legacy test file.

Reviewed changes

Copilot reviewed 17 out of 18 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
.circleci/config.yml Switch CI to CircleCI 2.1, Python 3.12 venv, run unit tests w/ coverage + run integration tests.
tests/base.py Introduce shared mock API data + helpers for integration tests.
tests/test_all_fields.py Integration coverage validating full field replication across streams using mock responses.
tests/test_automatic_fields.py Integration coverage validating all discovered fields are marked inclusion=automatic.
tests/test_bookmark.py Integration coverage for bookmark/state behavior during incremental syncs.
tests/test_discovery.py Integration coverage for discovery output correctness (streams, keys, schema).
tests/test_pagination.py Integration coverage for pagination behavior with mocked responses.
tests/test_start_date.py Integration coverage for start_date behavior in incremental vs full-table streams.
tests/test_sync.py End-to-end integration tests for sync() and CLI entrypoint behaviors.
tests/test_sync_canary.py Canary integration tests to ensure the pipeline emits schemas/records.
tests/unittests/__init__.py Make tests/unittests importable as a package.
tests/unittests/test_client.py Unit tests for HTTP client URL building and response handling.
tests/unittests/test_discover.py Unit tests for discovery helpers, catalog metadata, and stream configuration.
tests/unittests/test_init.py Broad unit tests covering multiple modules (state/transform/http/context/discover/sync).
tests/unittests/test_state.py Unit tests for state load/save/incorporation and bookmark parsing.
tests/unittests/test_sync.py Unit tests for Context, stream sync helpers, formatting, and main sync behavior.
tests/unittests/test_transform.py Unit tests for datetime path discovery + transformation utilities.
test/test_report_flattening.py Remove legacy flattening test under the old test/ path.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tests/test_bookmark.py
Comment thread tests/test_sync.py Outdated
Comment thread .circleci/config.yml Outdated
name: 'JSON Validator'
command: |
source /usr/local/share/virtualenvs/tap-tester/bin/activate
source /usr/local/share/virtualenvs/tap-codat/bin/activate
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should be tap-tester

@akkumar-qlik akkumar-qlik requested a review from RushiT0122 March 30, 2026 06:36
Comment thread CHANGELOG.md Outdated
Copy link
Copy Markdown

@RushiT0122 RushiT0122 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved but please fix changelog as suggested before merging.

Co-authored-by: Rushikesh Todkar <98420315+RushiT0122@users.noreply.github.com>
@akkumar-qlik akkumar-qlik changed the title upgrade python version to 3.12 and added unit, integration tests upgrade python version to 3.12 Apr 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants