Skip to content

fix: Fails when creating angular application/parcel#461

Merged
internettrans merged 4 commits intosingle-spa:mainfrom
jmrsnt:fix-angular-generator
Jul 12, 2025
Merged

fix: Fails when creating angular application/parcel#461
internettrans merged 4 commits intosingle-spa:mainfrom
jmrsnt:fix-angular-generator

Conversation

@jmrsnt
Copy link
Copy Markdown
Contributor

@jmrsnt jmrsnt commented Jul 11, 2025

Fix: Add shell: true to spawnSync options for Angular CLI on Windows

This PR fixes issue #403 by adding shell: true to the spawnSync options when executing ng.cmd.

Copy link
Copy Markdown
Member

@internettrans internettrans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread packages/generator-single-spa/src/angular/generator-single-spa-angular.js Outdated
jmrsnt and others added 2 commits July 11, 2025 16:13
…-angular.js

Co-authored-by: Jolyn <jolyndenning@gmail.com>
@jmrsnt jmrsnt requested a review from internettrans July 12, 2025 00:13
Comment thread .changeset/sour-onions-join.md Outdated
@internettrans internettrans merged commit c543908 into single-spa:main Jul 12, 2025
1 check passed
@jmrsnt jmrsnt deleted the fix-angular-generator branch July 13, 2025 00:09
@nickdeakin
Copy link
Copy Markdown

This code change is merged in as part of 5.0.10, but it seems 5.0.9 is the latest published version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants