Make destructors in polymorph classes virtual#4
Open
akohlmey wants to merge 4 commits intosingraber:masterfrom
Open
Make destructors in polymorph classes virtual#4akohlmey wants to merge 4 commits intosingraber:masterfrom
akohlmey wants to merge 4 commits intosingraber:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4 +/- ##
==========================================
- Coverage 72.27% 72.21% -0.06%
==========================================
Files 130 133 +3
Lines 14234 14252 +18
==========================================
+ Hits 10287 10292 +5
- Misses 3947 3960 +13
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some compilers don't like when destructors in polymorph classes are not virtual and complain about it.
This change silences those warnings.