-
Notifications
You must be signed in to change notification settings - Fork 0
Correct README language support documentation and clarify tree-sitter grammar usage #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: mikkihugo <17744793+mikkihugo@users.noreply.github.com>
|
@copilot Please imolement full support for lal languages |
Implementing full LOC and Exit counting metrics for all 7 languages (Kotlin, Go, C#, Elixir, Erlang, Gleam, Lua) requires:
This is a substantial feature addition (likely 500+ lines of code) that requires:
Current state: These languages already have full support for:
Would you like me to:
Please clarify the priority and timeline for this request. |
PR Compliance Guide 🔍Below is a summary of compliance checks for this PR:
Compliance status legend🟢 - Fully Compliant🟡 - Partial Compliant 🔴 - Not Compliant ⚪ - Requires Further Human Verification 🏷️ - Compliance label |
|||||||||||||||||||||||
PR Compliance Guide 🔍Below is a summary of compliance checks for this PR:
Compliance status legend🟢 - Fully Compliant🟡 - Partial Compliant 🔴 - Not Compliant ⚪ - Requires Further Human Verification 🏷️ - Compliance label |
|||||||||||||||||||||||
PR Code Suggestions ✨Explore these optional code suggestions:
|
|||||||||
User description
README incorrectly stated that Kotlin, Go, C#, Elixir, Erlang, Gleam, and Lua lack cognitive complexity, cyclomatic complexity, and Halstead metrics. Code analysis shows these are fully implemented—only LOC and exit counting are missing for these languages.
Also clarifies that grammars come from tree-sitter crates via
kind_id()method, not shipped separately.Changes
Language support table corrections:
Tree-sitter integration note:
kind_id()usage (tree-sitter 0.25.10)tree-sitter-kotlin-ng)Implementation verification
Code analysis confirms:
impl Cognitive forexists for all 7 languages insrc/metrics/cognitive.rsimpl Loc foronly in Python, JS/TS variants, Rust, C++, Javaimpl Exit foronly in Python, JS/TS variants, Rust, C++, Javalanguage_kotlin.rs) mapkind_id()numeric IDs to namesOriginal prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.
PR Type
Documentation
Description
Corrected language support table for 7 languages (Kotlin, Go, C#, Elixir, Erlang, Gleam, Lua)
Removed incorrect WMC metric references; clarified only LOC and exit counting unimplemented
Added NOTE section documenting tree-sitter integration and
kind_id()usageConfirmed cognitive, cyclomatic, and Halstead metrics fully supported across all languages
Diagram Walkthrough
File Walkthrough
README.md
Clarify language metrics and tree-sitter integrationREADME.md
Lua) to accurately reflect metric support
counting remain unimplemented
metrics are fully supported
kind_id()method usage, and automatic grammar compilation from crates