Skip to content

Split into crates, remove codecrafters leftovers#4

Merged
sinon merged 1 commit intomasterfrom
split-to-crates
Aug 2, 2025
Merged

Split into crates, remove codecrafters leftovers#4
sinon merged 1 commit intomasterfrom
split-to-crates

Conversation

@sinon
Copy link
Copy Markdown
Owner

@sinon sinon commented Aug 2, 2025

Why?

When working in codecrafters you were required to build a lexer, parser and eval that would output to stdout. Tests for previous sections were required to keep passing even when they were made obsolete by subsequent code. Since I am no longer using codecrafters there is a lot of code than can be deleted.

What?

Split into crates
Removed code that isn't needed by the main interpreter/run command

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 67.74194% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.2%. Comparing base (3c87e80) to head (2afa2d5).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
crates/loxide/src/interpreter.rs 33.3% 10 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
crates/lexer/src/lib.rs 100.0% <ø> (ø)
crates/loxide/src/builtins.rs 88.8% <ø> (ø)
crates/loxide/src/main.rs 100.0% <100.0%> (ø)
crates/loxide/src/value.rs 85.7% <ø> (ø)
crates/parser/src/lib.rs 84.7% <ø> (ø)
crates/loxide/src/interpreter.rs 73.1% <33.3%> (ø)

@sinon sinon merged commit 8232ad4 into master Aug 2, 2025
5 checks passed
@sinon sinon deleted the split-to-crates branch August 2, 2025 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants