[WIP] Feature/typings #65
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kakopappa
reviewed
Jan 15, 2024
|
|
||
|
|
||
| def set_color(device_id, r, g, b): | ||
| # TODO: is there a bit type (0-256)? |
There was a problem hiding this comment.
did you find an alternative to int? looks like only int valid here
kakopappa
reviewed
Jan 15, 2024
|
|
||
|
|
||
| def mode_value(device_id, mode_value, instance_id): | ||
| def mode_value(device_id: str, mode_value: Any, instance_id: str) -> tuple[bool, Any, str]: |
There was a problem hiding this comment.
I think mode_value can be str here.
kakopappa
reviewed
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added typings to the repo
Need to add more things.
This is still a work in progress.
@kakopappa I left some todos with questions.
What do you think about adding enums?
Feel free to leave asmany comments as you want