docs: add Vietnamese README (README.vi.md)#337
docs: add Vietnamese README (README.vi.md)#337quybquang wants to merge 4 commits intosipeed:mainfrom
Conversation
- Add full Vietnamese translation of README.md - Update language selector links in README.md, README.zh.md, README.ja.md
|
@quybquang look the conflicts please |
Leeaandrob
left a comment
There was a problem hiding this comment.
PR Review: docs: add Vietnamese README (README.vi.md)
Verdict: APPROVE ✅
@quybquang — Excellent work on this Vietnamese translation. The PR adds a comprehensive 859-line README.vi.md and updates navigation links across all existing READMEs. Here's my detailed analysis:
Findings
[MEDIUM] README.ja.md — Missing Chinese (中文) link (merge conflict with #327)
File: README.ja.md:15
Before (main):
**日本語** | [English](README.md)
After (this PR):
**日本語** | [Tiếng Việt](README.vi.md) | [English](README.md)
Expected:
**日本語** | [中文](README.zh.md) | [Tiếng Việt](README.vi.md) | [English](README.md)
The Chinese link was already missing before this PR (pre-existing issue), so this is not a regression. However, since you're already modifying this line, it would be ideal to include [中文](README.zh.md) for completeness.
Important: PR #327 is an open PR that specifically adds the missing Chinese link to README.ja.md. These two PRs modify the exact same line and will create a merge conflict. Whichever merges first will cause the other to need a rebase. I recommend coordinating with the maintainers on merge order, or proactively adding the Chinese link here to subsume #327's change.
Current nav link matrix:
| README | 中文 | 日本語 | Tiếng Việt | English |
|---|---|---|---|---|
| README.md | ✅ | ✅ | ✅ | bold |
| README.zh.md | bold | ✅ | ✅ | ✅ |
| README.ja.md | ❌ | bold | ✅ | ✅ |
| README.vi.md | ✅ | ✅ | bold | ✅ |
[LOW] glm-4.7 model reference in Quick Start (line 199)
The Quick Start config example uses "model": "glm-4.7". This faithfully reproduces the English README source, so it's not a translation error. However, glm-4.7 is being discussed for replacement in PR #209. Once the source README is updated, this file will need updating too. Not blocking.
[POSITIVE] Translation quality
The Vietnamese translation is comprehensive and well-executed:
- All sections from the English README are present and accurately translated
- Technical terms are appropriately handled (kept in English or with Vietnamese context)
- Code blocks, JSON configs, CLI commands, and tables are perfectly preserved
- All links (GitHub, external services, API providers) are intact
- The security caution block is accurately translated with appropriate urgency
- The
皮皮虾,我们走!slogan is correctly preserved (cultural element)
[POSITIVE] Navigation link updates
README.md and README.zh.md navigation links are correctly updated to include [Tiếng Việt](README.vi.md). The new README.vi.md itself has all 4 languages properly linked.
Summary
| Severity | Count | Details |
|---|---|---|
| CRITICAL | 0 | — |
| HIGH | 0 | — |
| MEDIUM | 1 | Missing [中文] link in README.ja.md (pre-existing, conflicts with #327) |
| LOW | 1 | glm-4.7 model reference (matches source, not blocking) |
| POSITIVE | 2 | Excellent translation quality, proper nav link updates |
Approving because this is a high-quality docs contribution. The Japanese README's missing Chinese link is a pre-existing issue that should be resolved (ideally in this PR to avoid the #327 conflict), but it's not a blocker for merge.
Suggested fix for README.ja.md:15:
**日本語** | [中文](README.zh.md) | [Tiếng Việt](README.vi.md) | [English](README.md)
Great contribution to the project's internationalization! 🦐
README.ja.md
Outdated
| <img src="https://img.shields.io/badge/license-MIT-green" alt="License"> | ||
| </p> | ||
|
|
||
| **日本語** | [English](README.md) |
There was a problem hiding this comment.
[MEDIUM] Missing Chinese link — merge conflict with PR #327
This line is missing [中文](README.zh.md). Since you're already modifying this line, consider adding it:
| **日本語** | [English](README.md) | |
| **日本語** | [中文](README.zh.md) | [Tiếng Việt](README.vi.md) | [English](README.md) |
PR #327 is open and modifies this exact same line to add the Chinese link. These will conflict on merge.
|
@quybquang take look |
ok bro |
|
@quybquang we have conflict now. Please take look into it |
There was a problem hiding this comment.
Pull request overview
Adds Vietnamese documentation support by introducing a full Vietnamese README translation and linking it from existing README language selectors.
Changes:
- Add a new Vietnamese README (
README.vi.md) with a full translation of project documentation. - Update language selector links in
README.md,README.zh.md, andREADME.ja.mdto include Vietnamese.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| README.md | Adds Vietnamese link to the language selector. |
| README.zh.md | Adds Vietnamese link to the language selector. |
| README.ja.md | Adds Vietnamese link to the language selector. |
| README.vi.md | New Vietnamese translation of the README content. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
README.vi.md
Outdated
| "discord": { | ||
| "enabled": true, | ||
| "token": "YOUR_BOT_TOKEN", | ||
| "allowFrom": ["YOUR_USER_ID"] |
There was a problem hiding this comment.
Trong snippet cấu hình Discord, key allowFrom không khớp với schema cấu hình thực tế (allow_from). Nên đổi thành allow_from để JSON unmarshal đúng.
| "allowFrom": ["YOUR_USER_ID"] | |
| "allow_from": ["YOUR_USER_ID"] |
| | Nhà cung cấp | Mục đích | Lấy API Key | | ||
| | --- | --- | --- | | ||
| | `gemini` | LLM (Gemini trực tiếp) | [aistudio.google.com](https://aistudio.google.com) | | ||
| | `zhipu` | LLM (Zhipu trực tiếp) | [bigmodel.cn](bigmodel.cn) | |
There was a problem hiding this comment.
Link [bigmodel.cn](bigmodel.cn) sẽ được GitHub hiểu như một relative link và bị hỏng. Nên dùng URL đầy đủ (ví dụ https://bigmodel.cn/...) để người đọc truy cập được.
| | `zhipu` | LLM (Zhipu trực tiếp) | [bigmodel.cn](bigmodel.cn) | | |
| | `zhipu` | LLM (Zhipu trực tiếp) | [bigmodel.cn](https://bigmodel.cn) | |
README.vi.md
Outdated
| "telegram": { | ||
| "enabled": true, | ||
| "token": "YOUR_BOT_TOKEN", | ||
| "allowFrom": ["YOUR_USER_ID"] |
There was a problem hiding this comment.
Trong snippet cấu hình Telegram, key allowFrom sẽ không được LoadConfig parse (schema dùng allow_from theo config/config.example.json và tag JSON trong pkg/config/config.go). Nên đổi allowFrom → allow_from để người dùng copy/paste hoạt động ngay.
| "allowFrom": ["YOUR_USER_ID"] | |
| "allow_from": ["YOUR_USER_ID"] |
|
@Leeaandrob I have resolved the conflict in README.ja.md as suggested. Please take another look! Thanks. |
bbe9462 to
7180a23
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
README.vi.md
Outdated
|
|
||
| ## 📢 Tin tức | ||
|
|
||
| 2026-02-16 🎉 PicoClaw đạt 12K stars chỉ trong một tuần! Cảm ơn tất cả mọi người! PicoClaw đang phát triển nhanh hơn chúng tôi tưởng tượng. Do số lượng PR tăng cao, chúng tôi cấp thiết cần maintainer từ cộng đồng. Các vai trò tình nguyện viên và roadmap đã được công bố [tại đây](doc/picoclaw_community_roadmap_260216.md) — rất mong đón nhận sự tham gia của bạn! |
There was a problem hiding this comment.
The path to the community roadmap document is incorrect. It should be docs/picoclaw_community_roadmap_260216.md (with 'docs' plural) instead of doc/picoclaw_community_roadmap_260216.md (with 'doc' singular). The correct path can be verified in the English README (line 52) and the actual file exists at docs/picoclaw_community_roadmap_260216.md.
| 2026-02-16 🎉 PicoClaw đạt 12K stars chỉ trong một tuần! Cảm ơn tất cả mọi người! PicoClaw đang phát triển nhanh hơn chúng tôi tưởng tượng. Do số lượng PR tăng cao, chúng tôi cấp thiết cần maintainer từ cộng đồng. Các vai trò tình nguyện viên và roadmap đã được công bố [tại đây](doc/picoclaw_community_roadmap_260216.md) — rất mong đón nhận sự tham gia của bạn! | |
| 2026-02-16 🎉 PicoClaw đạt 12K stars chỉ trong một tuần! Cảm ơn tất cả mọi người! PicoClaw đang phát triển nhanh hơn chúng tôi tưởng tượng. Do số lượng PR tăng cao, chúng tôi cấp thiết cần maintainer từ cộng đồng. Các vai trò tình nguyện viên và roadmap đã được công bố [tại đây](docs/picoclaw_community_roadmap_260216.md) — rất mong đón nhận sự tham gia của bạn! |
README.vi.md
Outdated
| <a href="https://x.com/SipeedIO"><img src="https://img.shields.io/badge/X_(Twitter)-SipeedIO-black?style=flat&logo=x&logoColor=white" alt="Twitter"></a> | ||
| </p> | ||
|
|
||
| [中文](README.zh.md) | [日本語](README.ja.md) | [English](README.md) | **Tiếng Việt** |
There was a problem hiding this comment.
The language selector order is inconsistent with other README files. The Vietnamese README places Vietnamese last but with English before it, which doesn't match the established patterns. Compare:
- Chinese README (line 17): 中文 (current/first) | Japanese | Vietnamese | English
- Japanese README (line 15): 日本語 (current/first) | Chinese | Vietnamese | English
- English README (line 17): Chinese | Japanese | Vietnamese | English (current/last)
- Vietnamese README (line 17): Chinese | Japanese | English | Tiếng Việt (current/last)
For consistency, Vietnamese should follow the same pattern as Chinese and Japanese by placing the current language first: Tiếng Việt | 中文 | 日本語 | English
| [中文](README.zh.md) | [日本語](README.ja.md) | [English](README.md) | **Tiếng Việt** | |
| **Tiếng Việt** | [中文](README.zh.md) | [日本語](README.ja.md) | [English](README.md) |
7180a23 to
bf5fcbb
Compare
bf5fcbb to
8428446
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "telegram": { | ||
| "enabled": true, | ||
| "token": "YOUR_BOT_TOKEN", | ||
| "allowFrom": ["YOUR_USER_ID"] | ||
| "allow_from": ["YOUR_USER_ID"] | ||
| } |
There was a problem hiding this comment.
The PR description only mentions adding the Vietnamese language link, but this hunk also changes the documented config key from allowFrom to allow_from in JSON examples. Please update the PR summary/description (or add a note in the README change list) so reviewers/users understand this additional documentation change.
There was a problem hiding this comment.
I agree with that json standard are snake case. @quybquang
Summary
Add Vietnamese translation of README.md for the Vietnamese developer community.
Changes
Notes