fix(telegram): use senderID and chatIDStr for message handling#371
Open
blib wants to merge 1 commit intosipeed:mainfrom
Open
fix(telegram): use senderID and chatIDStr for message handling#371blib wants to merge 1 commit intosipeed:mainfrom
blib wants to merge 1 commit intosipeed:mainfrom
Conversation
Signed-off-by: Boris Bliznioukov <blib@mail.com>
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in the Telegram channel's message handling where the sender and chat identifiers passed to HandleMessage didn't match the format used for allowlist checks. The code was constructing a compound senderID (including username) and chatIDStr for validation but then discarding them and recreating simpler numeric-only versions when calling HandleMessage, causing allowlist mismatches.
Changes:
- Reuses existing
senderIDandchatIDStrvariables inHandleMessagecall instead of reformatting numeric IDs
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
handleMessageconstructed a compoundsenderID("<id>|<username>") for the allowlist check but then passed only the numericfmt.Sprintf("%d", user.ID)toHandleMessage. This meant downstream consumers (session key, metadata, logs) never saw the username component, and—more importantly—thesenderIDstored in the inbound message wouldn't match allowlist entries that use the@usernameform.The same issue applied to
chatID: a separatechatIDStrwas already computed earlier in the function butHandleMessagewas called with a redundantfmt.Sprintf("%d", chatID).This PR reuses the already-computed
senderIDandchatIDStrvariables, fixing the mismatch and removing the duplicate formatting.🗣️ Type of Change
🤖 AI Code Generation
🔗 Linked Issue
#310
📚 Technical Context (Skip for Docs)
senderIDwas built asfmt.Sprintf("%d|%s", user.ID, user.Username)on L204 butHandleMessageon L358 was called withfmt.Sprintf("%d", user.ID), discarding the username part. The fix is a one-line change reusing the existing locals.