fix(exec): kill child process tree on timeout to prevent orphaned tasks#378
Open
lunareed720 wants to merge 1 commit intosipeed:mainfrom
Open
fix(exec): kill child process tree on timeout to prevent orphaned tasks#378lunareed720 wants to merge 1 commit intosipeed:mainfrom
lunareed720 wants to merge 1 commit intosipeed:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes orphaned background processes when
execcommands time out.What changed
Setpgid: true)kill -SIGKILL -pgid)taskkill /T /F /PIDfallbackExecToolexecution flow toStart + Waitwith explicit timeout path and cleanupsleep) does not leave child process aliveWhy
Issue #311 reports that failed/timed-out shell commands keep running in background. This can leak resources and degrade long-running agent stability.
Testing
go test ./pkg/tools -run TestShellTool -count=1Closes #311