Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tighten CLI input handling, fix a TTY rendering collision, add a README
demo, and wire up markdown linting so docs stay clean going forward.
Changes
dibs verify mybrandnow errors with a shell-safe suggestion(
did you mean: dibs --verify "mybrand") instead of silently droppingthe second arg. Values with whitespace are
%q-quoted so thesuggestion round-trips through a shell.
Renderer.BeginVerification(count)hook.Terminal clears its in-place progress bar before printing so the two
don't collide on the same line. CSV/JSON treat it as a no-op.
colorGreenswitched from ANSI 32 to 92 so available-domain linesstay legible on muted themes (TokyoNight, Solarized).
config_test.go.vhs-rendered demo GIF and carries release /Go Reference / Report Card badges. CONTRIBUTING documents how to
regenerate the demo from
demo/demo.tape.markdownlint-cli2with aline_length: 85config, amake docs-linttarget, and wired it intomake release-check.Reflowed all prose in README, CONTRIBUTING, and CODE_OF_CONDUCT to
comply.
Type of Change
Testing
go test ./...passes (174 tests,-raceclean)go vet ./...passesmake release-checkfully green (fmt, vet, lint, markdownlint,race, deadcode, govulncheck, mod verify/tidy, reproducible build)
Checklist
(
TestRejectsExtraPositionalArgs,TestTerminalRenderer_BeginVerificationClearsProgressBarOnTTY)