Do not fetch ContentViewhelper nodes recursively#157
Open
sascha-egerer wants to merge 3 commits intositegeist:masterfrom
Open
Do not fetch ContentViewhelper nodes recursively#157sascha-egerer wants to merge 3 commits intositegeist:masterfrom
sascha-egerer wants to merge 3 commits intositegeist:masterfrom
Conversation
Content ViewHelpers should only be fetched as direct children, not recursively. Fetching them recursively in templates will not work if components are nested, as slots of the inner component would also be applied to the outer component. Placing content in an if-else block, thus defining the content twice, will also not work and would no longer be possible with this change, which should prevent some headaches.
Collaborator
|
Not sure about the general state of the tests, but this seems to break a lot of them that test slot functionality. |
Author
|
Yes sorry it is broken. I’m working on it. I thought I did not yet open the PR. Will push a new version later and also add tests |
Author
|
@s2b I have added two new tests with nested components that are using slots. |
ulrichmathes
force-pushed
the
master
branch
2 times, most recently
from
347e14d to
c676bcd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Content ViewHelpers should only be fetched as direct children, not recursively. Fetching them recursively in templates will not work if components are nested, as slots of the inner component would also be applied to the outer component. Placing content in an if-else block, thus defining the content twice, will also not work and would no longer be possible with this change, which should prevent some headaches.