Make component settings work in TYPO3 v13#174
Open
sascha-egerer wants to merge 2 commits intositegeist:masterfrom
Open
Make component settings work in TYPO3 v13#174sascha-egerer wants to merge 2 commits intositegeist:masterfrom
sascha-egerer wants to merge 2 commits intositegeist:masterfrom
Conversation
Component settings based on typoscript must be read from the request. Currently there is no clean way to get the request in the component settings object. ComponentSettings should be refactored but this'll we a breaking change as it requires some major changes like removing the singleton pattern.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Component settings based on typoscript must be read from the request.
Currently there is no clean way to get the request in the component settings object.
ComponentSettings should be refactored but this'll we a breaking change as it requires
some major changes like removing the singleton pattern.