Skip to content

Commit a66e764

Browse files
committed
changed: decoupled from the specific file system
1 parent 39a2c9b commit a66e764

File tree

3 files changed

+19
-17
lines changed

3 files changed

+19
-17
lines changed

examples/Settings/MultiWiFi/MultiWiFi.ino

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -28,12 +28,11 @@
2828
#include <WiFi.h>
2929
#endif
3030

31-
#include "FS.h"
32-
#include "LittleFS.h"
33-
#include "ArduinoJson.h"
31+
#include <LittleFS.h>
32+
#include <ArduinoJson.h>
3433

35-
#include "SinricPro.h"
36-
#include "SinricProSwitch.h"
34+
#include <SinricPro.h>
35+
#include <SinricProSwitch.h>
3736
#include "SinricProWiFiSettings.h"
3837

3938
#define APP_KEY "" // Should look like "de0bxxxx-1x3x-4x3x-ax2x-5dabxxxxxxxx"
@@ -52,7 +51,7 @@ const char* primaryPassword = ""; // Set to your primary wifi's password
5251
const char* secondarySSID = ""; // Set to your secondary wifi's ssid
5352
const char* secondaryPassword = ""; // Set to your secondary wifi's password
5453

55-
SinricProWiFiSettings spws(primarySSID, primaryPassword, secondarySSID, secondaryPassword, "/wificonfig.dat");
54+
SinricProWiFiSettings spws(LittleFS, primarySSID, primaryPassword, secondarySSID, secondaryPassword, "/wificonfig.dat");
5655

5756
bool onSetModuleSetting(const String& id, const String& value) {
5857
// Handle module settings.

examples/Settings/MultiWiFi/SinricProWiFiSettings.cpp

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,11 @@
11
#include "SinricProWiFiSettings.h"
22

3-
SinricProWiFiSettings::SinricProWiFiSettings(const char* defaultPrimarySSID, const char* defaultPrimaryPassword,
3+
SinricProWiFiSettings::SinricProWiFiSettings(fs::FS& fs,
4+
const char* defaultPrimarySSID, const char* defaultPrimaryPassword,
45
const char* defaultSecondarySSID, const char* defaultSecondaryPassword,
56
const char* configFileName)
6-
: defaultPrimarySSID(defaultPrimarySSID), defaultPrimaryPassword(defaultPrimaryPassword),
7+
: fs(fs)
8+
, defaultPrimarySSID(defaultPrimarySSID), defaultPrimaryPassword(defaultPrimaryPassword),
79
defaultSecondarySSID(defaultSecondarySSID), defaultSecondaryPassword(defaultSecondaryPassword),
810
configFileName(configFileName) {
911
memset(&wifiSettings, 0, sizeof(wifiSettings));
@@ -46,9 +48,9 @@ void SinricProWiFiSettings::printSettings() const {
4648
void SinricProWiFiSettings::saveToFile() {
4749

4850
#if defined(ESP8266)
49-
File file = LittleFS.open(configFileName, "w");
51+
File file = fs.open(configFileName, "w");
5052
#elif defined(ESP32)
51-
File file = LittleFS.open(configFileName, FILE_WRITE);
53+
File file = fs.open(configFileName, FILE_WRITE);
5254
#endif
5355

5456
if (file) {
@@ -59,9 +61,9 @@ void SinricProWiFiSettings::saveToFile() {
5961

6062
bool SinricProWiFiSettings::loadFromFile() {
6163
#if defined(ESP8266)
62-
File file = LittleFS.open(configFileName, "r");
64+
File file = fs.open(configFileName, "r");
6365
#elif defined(ESP32)
64-
File file = LittleFS.open(configFileName, FILE_READ);
66+
File file = fs.open(configFileName, FILE_READ);
6567
#endif
6668

6769
if (file && file.size() == sizeof(wifiSettings)) {
@@ -85,8 +87,8 @@ void SinricProWiFiSettings::saveDefaultSettings() {
8587

8688
void SinricProWiFiSettings::deleteAllSettings() {
8789
memset(&wifiSettings, 0, sizeof(wifiSettings));
88-
if (LittleFS.exists(configFileName)) {
89-
LittleFS.remove(configFileName);
90+
if (fs.exists(configFileName)) {
91+
fs.remove(configFileName);
9092
}
9193
Serial.println("All WiFi settings have been deleted.");
9294
}

examples/Settings/MultiWiFi/SinricProWiFiSettings.h

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
11
#pragma once
22

33
#include <Arduino.h>
4-
#include "FS.h"
5-
#include "LittleFS.h"
4+
#include <FS.h>
65

76

87
/**
@@ -26,7 +25,8 @@ class SinricProWiFiSettings {
2625
* @param defaultSecondaryPassword Default secondary password.
2726
* @param configFileName File name for storing WiFi settings.
2827
*/
29-
SinricProWiFiSettings(const char* defaultPrimarySSID, const char* defaultPrimaryPassword,
28+
SinricProWiFiSettings(fs::FS& fs,
29+
const char* defaultPrimarySSID, const char* defaultPrimaryPassword,
3030
const char* defaultSecondarySSID, const char* defaultSecondaryPassword,
3131
const char* configFileName);
3232

@@ -71,6 +71,7 @@ class SinricProWiFiSettings {
7171
const wifi_settings_t& getWiFiSettings() const;
7272

7373
private:
74+
fs::FS& fs; // filesystem to be used
7475
const char* defaultPrimarySSID; ///< Default primary SSID.
7576
const char* defaultPrimaryPassword; ///< Default primary password.
7677
const char* defaultSecondarySSID; ///< Default secondary SSID.

0 commit comments

Comments
 (0)