You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
HI, @johnbailon
Looks good to me. Just in case, please give me the documentation about this. Thanks.
Sure @sivchari, basically, I just added the error that would come from Twitter on to the response of PostTweet. I made sure to follow your conventions and I modified the test to take into account the changes I made.
Context: I needed to know what was causing my PostTweet requests to fail and the current version doesn't provide the erro response from Twitter.
@johnbailon
Sorry, too late to respond. I concern if this response is really had errors field. Have you confirmed it ? If yes, please paste the response. Because I want to confirm it just in case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Post tweet doesn't return the full response when the request is not successful. I added details from Twitter API's response to the returned object.