Append ellipse only if text is truncated#28
Open
chrispelzer wants to merge 1 commit intosixlive:masterfrom
Open
Append ellipse only if text is truncated#28chrispelzer wants to merge 1 commit intosixlive:masterfrom
chrispelzer wants to merge 1 commit intosixlive:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When implementing this for files within our Nova app that are long values. I noticed that when the length is less than the truncated value passed to TextCopy it will append the ellipse (...) to the text regardless if it was truncated or not.
This checks the length of the text and determines if it is greater than truncate to then output the ellipse.
Related Issues
None
Related PRs
None
Steps to Verify Functionality
If you have text length of (n) and truncate is set to (n-1) then you SHOULD see the ellipse (...) to the left of the Copy button.
If you have text length of (n) and truncate is set to (n) then you SHOULDN'T see the ellipse (...) to the left of the Copy button.