-
Notifications
You must be signed in to change notification settings - Fork 0
Type check #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Type check #4
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
a4882fb
chore: add linting and type checking setup
sjblurton cb4d8d4
fix(tests): update JSON string formatting in TodosStorageService tests
sjblurton ba8f299
chore: set up ESLint configuration and update pre-commit hook
sjblurton d6736f9
chore: update package-lock.json
sjblurton 021d30b
chore: remove extraneous dependencies from package-lock.json
sjblurton a5cc08b
Potential fix for pull request finding
sjblurton 01ed339
Potential fix for pull request finding
sjblurton b49564a
Potential fix for pull request finding
sjblurton 5e4e90c
Potential fix for pull request finding
sjblurton ad366d1
Potential fix for pull request finding
sjblurton 9a6b2d7
Update default Node.js version to '22.x' in CI setup and workflows
sjblurton 5d652ce
Remove ESLint configuration file
sjblurton 6c06a20
Uncomment npm version alignment step in CI workflows
sjblurton 8583590
Refactor ESLint configuration for TypeScript and HTML files
sjblurton b88d12b
Refactor CI workflow to simplify Node.js setup and remove redundant s…
sjblurton f11e1a8
Update @angular-eslint packages to version 21.3.1 and comment out npm…
sjblurton 0aadf7e
Remove commented npm version alignment step from CI setup
sjblurton bb809fa
Update schematicCollections to use the correct namespace for @angular…
sjblurton ecd1bc0
Add recommended and accessibility rules for @angular-eslint/template
sjblurton File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| name: Lint & Type Check | ||
|
|
||
| on: | ||
| push: | ||
| branches: [main, develop] | ||
| pull_request: | ||
| branches: [main, develop] | ||
|
|
||
| jobs: | ||
| lint: | ||
| runs-on: ubuntu-latest | ||
|
|
||
| strategy: | ||
| matrix: | ||
| node-version: [22.x] | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v4 | ||
|
|
||
| - name: Setup CI | ||
| uses: ./.github/actions/setup-ci | ||
| with: | ||
| node-version: ${{ matrix.node-version }} | ||
|
|
||
| - name: Run ESLint | ||
| run: npm run lint | ||
|
|
||
| - name: Run TypeScript type check | ||
| run: npm run type-check |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| npm run lint-staged | ||
sjblurton marked this conversation as resolved.
Show resolved
Hide resolved
sjblurton marked this conversation as resolved.
Show resolved
Hide resolved
sjblurton marked this conversation as resolved.
Show resolved
Hide resolved
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| { | ||
| "*.ts": ["eslint --fix", "prettier --write"] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.