Skip to content

Conversation

@suhanmappingideas
Copy link
Collaborator

No description provided.

Copy link
Owner

@sjsrey sjsrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good first pr.

A couple of things to keep in mind when using git and github. The system will keep track of the differences and changes between files, so no need to have the names serve that purpose. So for example, Highlighted_Polygons2.py should be Highlighted_Polygons.py.

renanxcortes and others added 14 commits July 25, 2018 14:11
I embedded my newest version in your version resulting in this code. I'm proposing this file change.
Merging my current state with your current state
Updating last version and integrating space-travel in the densitites
Changes made (please, check if you agree with them, Su):

- Remove the + 1 of the rank because it was starting in the second position in the space travel.

- Added the highlighted dot to the timepath.

- Chenged to 'Multiple States'scatter title when selecting multiple states in the map.

- Inverted the positions of the message when doing the spacetravel (I think it makes more the sense the richest being the First (1th), do you agree?
Updating and making for changes
It is the same version of the meeting of 30th July, but I reversed the ranks in the subtitle of the choropleth. Now, the poorest is 1st.
I just added the clickData event for the scatterplot, but I realized that when you click on the scatterplot, the clickData for the choropleth won't work because of the if else statements, I have to figure out how to overcome this, because there's no way to clear theclickData. In addition, there is a tab for the rankpath, which I'm doing.
I fixed the border polygons by extracting the biggest polygon of the multipolygon object in python by creating the function 'return_biggest'.
This is a PR for you to see the rank paths would be possible using plotly. I have to clean the code a little bit and colors and the alignment are still missing to fix.
This is a version to deploy the current dashboard made in Dash with a simple layout. Su, I chose to supress the reactives of the scatterPlot (clickdata) and let only the ones with the choropleth, because since there's no way (at least, not simple way) to clear the clickData or select data, there's no way to keep the user changing to click on either choropleth or scatter plot freely, because the user will eventually not able to refresh using the other option.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants