Increase max configurable line length from config#78
Open
SimonCahill wants to merge 2 commits intoskeeto:masterfrom
Open
Increase max configurable line length from config#78SimonCahill wants to merge 2 commits intoskeeto:masterfrom
SimonCahill wants to merge 2 commits intoskeeto:masterfrom
Conversation
Allow banner lines up to 4096 chars in length from config
…-length Update endlessh.c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because the SSH spec doesn't mention any max length of the banner size, it can be assumed that line lengths aren't checked, either. In this case, increasing the max line length (from config) may cause buffer overflows in systems attempting to gain access to servers running this tarpit. Causing buffer overflows in bot systems is a non-issue, and personally I'd encourage it.
If it leads to system instability, fine by me and I'm sure many others will agree.