WIP:MacOS shared folder config + cached option#38
WIP:MacOS shared folder config + cached option#38iberdinsky-skilld wants to merge 4 commits intoskilld-labs:masterfrom
Conversation
| restart: always | ||
| networks: | ||
| - front | ||
|
|
There was a problem hiding this comment.
here better to add then override for ports of mailhog too.
ports: - "8025:8025"
There was a problem hiding this comment.
There was a problem hiding this comment.
yep Macos needs portmapping, better to add it here
andypost
left a comment
There was a problem hiding this comment.
I found only 2 issues: naming of mysql var & expose port for mailhog
| COMPOSER_REQUIRE=solarium/solarium:3.6.* | ||
| PROJECT_INSTALL= | ||
| PHP_VERSION=7.1 | ||
| SHARED_FOLDER=/dev/shm |
There was a problem hiding this comment.
please give it better name a-la MYSQL_DATA_DIR
| restart: always | ||
| networks: | ||
| - front | ||
|
|
There was a problem hiding this comment.
yep Macos needs portmapping, better to add it here
|
In .env file we have also we have OS-detection and it can be used to handle os-specific tasks |
Two things done here: