Skip to content

WIP added gridlex layout#16

Open
iberdinsky-skilld wants to merge 1 commit intoskilld-labs:8.x-7.xfrom
iberdinsky-skilld:8.x-7.x
Open

WIP added gridlex layout#16
iberdinsky-skilld wants to merge 1 commit intoskilld-labs:8.x-7.xfrom
iberdinsky-skilld:8.x-7.x

Conversation

@iberdinsky-skilld
Copy link
Copy Markdown
Collaborator

Gridlex layout is cool. Simple and flexbox. http://gridlex.devlint.fr/

  1. We can have class for parent element only. Or child. Or both
  2. Various classes for alignment
  3. Combine bootstrap order with flexbox power. Plus list of mixins.

For test install drupal(+components). zen and subtheme. npm install in subtheme. basic page layout using gridlex alread.

@andriyun
Copy link
Copy Markdown
Member

andriyun commented May 3, 2017

Would be cool to add some info about this grid to README

@iberdinsky-skilld
Copy link
Copy Markdown
Collaborator Author

i'm not sure what for? http://gridlex.devlint.fr/ has well described demo page
maybe only this part https://github.com/devlint/gridlex/blob/master/README.md#3-ways-to-use-gridlex

@andriyun
Copy link
Copy Markdown
Member

andriyun commented May 3, 2017

At least to have references to http://gridlex.devlint.fr/ in scope of this repo

@andriyun andriyun self-requested a review May 3, 2017 19:38
Copy link
Copy Markdown
Member

@andriyun andriyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for me
Tested on fresh drupal install
Looks ok

// Add the Zen Grids responsive layout mixins.
@import 'zen-grids';
// Add the Gridlex flexbox library http://gridlex.devlint.fr/.
@import 'gridlex/src/gridlex-vars';
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is grid system. and not related to layouts as is. we may use this gridlex to create any layout we need. but that commit not contains them.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about not standard layouts, not 12col. May be we can check susy?

@andriyun andriyun assigned andriyun and hog-seruj and unassigned andriyun Jun 23, 2017

$gl-gutter: 1rem;

$gl-xs: 'screen and (max-width: 640px)';
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use 3 breakpoints for example?

Like this:
0-640
641-1024
1025 - ~

// Add the Zen Grids responsive layout mixins.
@import 'zen-grids';
// Add the Gridlex flexbox library http://gridlex.devlint.fr/.
@import 'gridlex/src/gridlex-vars';
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about not standard layouts, not 12col. May be we can check susy?

@koskinpark
Copy link
Copy Markdown

koskinpark commented Aug 11, 2017

You have to add
files: ignore: - 'components/gridlex/**'

in .sass-lint.yml file to ignore linting for gridlex.
https://github.com/sasstools/sass-lint#files

@iberdinsky-skilld
Copy link
Copy Markdown
Collaborator Author

Susy gives more freedom to build custom layouts.
#33
But anyway we may disquss any "out of box" class names. Using gridlex bootstrap whatever.

@iberdinsky-skilld iberdinsky-skilld changed the title added gridlex layout WIP added gridlex layout Nov 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants