errorHandlingStop | Added config to stop process on error#23
Open
Drintios wants to merge 8 commits intoskilld-labs:8.x-7.xfrom
Open
errorHandlingStop | Added config to stop process on error#23Drintios wants to merge 8 commits intoskilld-labs:8.x-7.xfrom
Drintios wants to merge 8 commits intoskilld-labs:8.x-7.xfrom
Conversation
Contributor
|
It needs some polishing, and review https://github.com/acquia-pso/cog/blob/8.x-1.x/STARTERKIT/gulp-tasks/lint-css.js#L34 |
pabloguerino
suggested changes
Jun 30, 2017
| } | ||
|
|
||
| // Convenience handler for error-level errors. | ||
| function onError(error) { |
Contributor
There was a problem hiding this comment.
I think we can include the code for the function handleError inside the onError function, right?
as you are changing it's scope, but doesn't seems like it's required.
Gulp clone taks instead drush zen command. Cleanup unsed zen theme files
Contributor
Author
|
Added recommended changes by @pabloguerino Still have one issue i tried to exit process on eslint error using eslint.results and errorCount to determine if error but every time it stops it hangs and i need to stop gulp manually. To test this behavior you can add |
Contributor
|
FYI tested current |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added these to stop everything if error is found