WIP: Added composer to theme. Added 'asset-packagist'.#34
WIP: Added composer to theme. Added 'asset-packagist'.#34
Conversation
hog-seruj
changed the title
andypost
left a comment
andypost
left a comment
There was a problem hiding this comment.
Lots of unneeded chages
| @@ -0,0 +1,35 @@ | |||
| { | |||
| "name": "drupal/skilld-zen", | |||
There was a problem hiding this comment.
name should be skilld-labs/zen as repo
| @@ -0,0 +1,267 @@ | |||
| { | |||
| "_readme": [ | |||
There was a problem hiding this comment.
do not commit lock file in starterkit
| "require": { | ||
| "oomphinc/composer-installers-extender": "^1.1", | ||
| "fxp/composer-asset-plugin": "~1.3", | ||
| "npm-asset/slick-carousel": "^1.7" |
There was a problem hiding this comment.
are you sure that carousel is required?
There was a problem hiding this comment.
Yes, because in all projects we install this librarie and write base configuration for it. Also will be ok to add FontAwesome or another font with icons.
| "npm-asset" | ||
| ], | ||
| "installer-paths": { | ||
| "libraries/{$name}": [ |
There was a problem hiding this comment.
Why do we need libraries folder and not just vendor ?
There was a problem hiding this comment.
According to our theme structure all libraries stacked in folder 'libraries'.
| ], | ||
| "authors": [ | ||
| { | ||
| "name": "HOG", |
There was a problem hiding this comment.
I guess that better set it to 'skilld'
There was a problem hiding this comment.
NP. I'll change it.
3 participants
http://lightning.acquia.com/blog/round-your-front-end-javascript-libraries-composer