-
Notifications
You must be signed in to change notification settings - Fork 446
fix: modify step 3 grading to check for changed files instead of specific keywords #117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: FidelusAleksander <63016446+FidelusAleksander@users.noreply.github.com>
Co-authored-by: FidelusAleksander <63016446+FidelusAleksander@users.noreply.github.com>
Co-authored-by: FidelusAleksander <63016446+FidelusAleksander@users.noreply.github.com>
Co-authored-by: FidelusAleksander <63016446+FidelusAleksander@users.noreply.github.com>
Co-authored-by: FidelusAleksander <63016446+FidelusAleksander@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the grading mechanism for step 3 to check if files were modified rather than searching for specific keywords. The change addresses user reports where Copilot made adequate changes without using the required "participant" keyword.
Key Changes:
- Replaced keyword-based validation with file modification detection
- Added
tj-actions/changed-files@v47action to detect changed files - Updated validation logic to check if
app.jsandstyles.csswere modified compared to the main branch
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
In general can't you check for the files and a word that is consistent instead of making these changes? Does this add additional actions from the marketplace that we haven't used before? KISS 😄 |
chriswblake
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks for attaching the test run.
I would fix the embedded variable. Shouldn't be a problem here, but better safe than sorry.
Hey that's what was the original approach - to check for Like this one #25 Now the steps will pass more gracefully with any changes to these files. I believe we also use tj-actions/changed-files in one or a few other exercises for grading |
Summary
This is a long needed update to be less strict on step 3 grading where we checked for specific keywords. Users reported that copilot sometimes did the adequate changes but did not use the
participantkeywordTest run issue: FidelusAleksander/skills-getting-started-with-github-copilot-step-3-grading#1
Changes
The grading now only checks if both files were changed compared to the
mainbranchCloses: #111
Copilot summary
This pull request updates the workflow in
.github/workflows/3-copilot-edits.ymlto improve how it checks for modifications toapp.jsandstyles.cssas part of a practical exercise. The main changes include switching from keyphrase-based checks to verifying that the files were actually modified, and updating the step descriptions accordingly.Workflow improvements for file modification checks:
skills/action-keyphrase-checker) with explicit checks that confirm whethersrc/static/app.jsandsrc/static/styles.csswere modified, usingtj-actions/changed-filesandactions/github-script. This ensures that participants actually edit the required files.Task list