Skip to content

Mark debug builds in skip --help and skip doctor#169

Open
dfabulich wants to merge 1 commit intoskiptools:mainfrom
dfabulich:debug-version
Open

Mark debug builds in skip --help and skip doctor#169
dfabulich wants to merge 1 commit intoskiptools:mainfrom
dfabulich:debug-version

Conversation

@dfabulich
Copy link
Contributor

Before, when running my own hand-built Skip:

% ./skip --help | grep OVERVIEW
OVERVIEW: skip 1.7.0
% PATH=.:$PATH ./skip doctor | grep "Skip version"
[✓] Skip version 1.7.0 (= 1.7.0)
% ./skip --help | grep OVERVIEW
OVERVIEW: skip 1.7.0 (debug)
% PATH=.:$PATH ./skip doctor | grep "Skip version"
[!] Skip version 1.7.0 (debug)

(I think there might be a better way to mark official builds with isOfficial or something? But this is good for a start.)

Skip Pull Request Checklist:

  • REQUIRED: I have signed the Contributor Agreement
  • REQUIRED: I have tested my change locally with swift test
  • OPTIONAL: I have tested my change on an iOS simulator or device
  • OPTIONAL: I have tested my change on an Android emulator or device

@cla-bot cla-bot bot added the cla-signed label Jan 21, 2026
return (result, MessageBlock(status: .fail, "Skip version: error executing \(skipcmd)"))
}
if skipVersion.contains("debug") {
return (result, MessageBlock(status: .warn, skipVersion))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm confused by this. If we are running a local debug build of skip, don't we want the version that it forks to also be the same debug build? Why is it a .warn scenario when the forked version contains "debug"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments