Mark debug builds in skip --help and skip doctor#169
Open
dfabulich wants to merge 1 commit intoskiptools:mainfrom
Open
Mark debug builds in skip --help and skip doctor#169dfabulich wants to merge 1 commit intoskiptools:mainfrom
skip --help and skip doctor#169dfabulich wants to merge 1 commit intoskiptools:mainfrom
Conversation
marcprux
reviewed
Feb 4, 2026
| return (result, MessageBlock(status: .fail, "Skip version: error executing \(skipcmd)")) | ||
| } | ||
| if skipVersion.contains("debug") { | ||
| return (result, MessageBlock(status: .warn, skipVersion)) |
Member
There was a problem hiding this comment.
I'm confused by this. If we are running a local debug build of skip, don't we want the version that it forks to also be the same debug build? Why is it a .warn scenario when the forked version contains "debug"?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before, when running my own hand-built Skip:
(I think there might be a better way to mark official builds with
isOfficialor something? But this is good for a start.)Skip Pull Request Checklist:
swift test