doctor: Print xcode-select hint if active dev dir is CommandLineTools#180
Open
dfabulich wants to merge 1 commit intoskiptools:mainfrom
Open
doctor: Print xcode-select hint if active dev dir is CommandLineTools#180dfabulich wants to merge 1 commit intoskiptools:mainfrom
xcode-select hint if active dev dir is CommandLineTools#180dfabulich wants to merge 1 commit intoskiptools:mainfrom
Conversation
4 tasks
marcprux
reviewed
Feb 12, 2026
|
|
||
| /// Check Xcode version with special handling for CommandLineTools error (https://github.com/skiptools/skip/issues/609). | ||
| func checkXcodeVersion(with out: MessageQueue) async throws { | ||
| let xcodeDeveloperPath = "/Applications/Xcode.app/Contents/Developer" |
Member
There was a problem hiding this comment.
Can we check the DEVELOPER_DIR environment variable here in case someone wants to use a beta (or other custom) version of Xcode?
Contributor
Author
There was a problem hiding this comment.
I'm not sure that's meaningful in this case. xcodeDeveloperPath is only used here to suggest a command for the user to run, if xcodebuild -version fails because they've xcode-selected CommandLineTools.
If they've xcode-selected the release build of Xcode, but they intended to use an Xcode beta, they probably didn't have the presence of mind to set DEVELOPER_DIR. And since xcodebuild -version will succeed in that case, skip doctor is just going to print "[✓] Xcode version 26.2 (> 15.0.0)", so we wouldn't print any error message at all.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes skiptools/skip#609
Skip Pull Request Checklist:
swift test