Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions Sources/SkipSyntax/Kotlin/KotlinExpressionTypes.swift
Original file line number Diff line number Diff line change
Expand Up @@ -956,6 +956,9 @@ final class KotlinFunctionCall: KotlinExpression, KotlinMainActorTargeting, APIC
if let number128Init = number128InitFunction(expression: expression, arguments: karguments) {
return number128Init
}
if let boolToggle = boolToggleToAssignment(expression: expression, translator: translator) {
return boolToggle
}

let kfunction = translator.translateExpression(expression.function)
// E.g. [Int](), [String: Int]()
Expand Down Expand Up @@ -1034,6 +1037,20 @@ final class KotlinFunctionCall: KotlinExpression, KotlinMainActorTargeting, APIC
return kexpression
}

private static func boolToggleToAssignment(expression: FunctionCall, translator: KotlinTranslator) -> KotlinExpression? {
guard expression.arguments.isEmpty,
let memberAccess = expression.function as? MemberAccess,
memberAccess.member == "toggle",
memberAccess.baseType == .bool,
let base = memberAccess.base else {
return nil
}
let klhs = translator.translateExpression(base)
let krhsTarget = translator.translateExpression(base)
let krhs = KotlinPrefixOperator(operatorSymbol: "!", target: krhsTarget, sourceFile: expression.sourceFile, sourceRange: expression.sourceRange)
return KotlinBinaryOperator(op: Operator.with(symbol: "="), lhs: klhs, rhs: krhs, sourceFile: expression.sourceFile, sourceRange: expression.sourceRange)
}

private static func isFunction(expression: FunctionCall, named: String, moduleName: String) -> Bool {
if let identifier = expression.function as? Identifier {
return identifier.name == named
Expand Down
14 changes: 14 additions & 0 deletions Tests/SkipSyntaxTests/BuiltinTypeTests.swift
Original file line number Diff line number Diff line change
Expand Up @@ -670,4 +670,18 @@ final class BuiltinTypeTests: XCTestCase {
get() = 4.0
""")
}

func testBoolToggle() async throws {
try await check(swift: """
{
var flag: Bool = true
flag.toggle()
}
""", kotlin: """
{ ->
var flag: Boolean = true
flag = !flag
}
""")
}
}