Fix test resources in Xcode when running in symlinked directory#185
Merged
marcprux merged 1 commit intoskiptools:mainfrom Feb 19, 2026
Merged
Fix test resources in Xcode when running in symlinked directory#185marcprux merged 1 commit intoskiptools:mainfrom
marcprux merged 1 commit intoskiptools:mainfrom
Conversation
`/tmp` on macOS is a symlink to `/private/tmp`. We need to canonicalize both paths with `(path as NSString).standardizingPath` before we call `.hasPrefix` on them.
Member
|
Looks good, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes skiptools/skip#622
/tmpon macOS is a symlink to/private/tmp. We need to canonicalize both paths with(path as NSString).standardizingPathbefore we call.hasPrefixon them.Skip Pull Request Checklist:
swift testI used Cursor to automatically add logging statements. It found the path mismatch and fixed it, and I reviewed the result (all six lines).