Skip to content

feat(fe): modify mainpage mainbanner and midbanner design #3166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
borayo wants to merge 16 commits into
base: main
Choose a base branch
from
Open

feat(fe): modify mainpage mainbanner and midbanner design #3166

borayo wants to merge 16 commits into from

Conversation

@borayo
Copy link
Contributor

@borayo borayo commented Sep 16, 2025 •
edited by Kimhyojung0810
Loading

Description

  • 메인배너와 중간배너의 변경된 디자인 사항을 수정합니다.
  • 변경된 사항은 아래와 같습니다.

메인 배너 변경된 부분

  • 가로 폭 변경
  • 메인 title 폰트 유형 변경
  • 좌우 Arrow 영역 또한 가로, 세로값 변경
  • 이미지 위치 등 변경

중간배너 수정된 부분

  • 가로 폭 수정
  • 우측 이미지 비율 변경
  • 텍스트 영역과 왼쪽 마진값 변경됨

https://www.figma.com/design/c7RefqPCB4HC9DuFhT7eFg/%EC%BD%94%EB%93%9C%EB%8B%B9-%EB%A6%AC%EB%94%94%EC%9E%90%EC%9D%B8--2025ver-?node-id=19454-19991&t=FG8DEjxoSOMRYhHS-1

@borayo borayo requested review from egg-zz and seoeun9 September 16, 2025 09:25
@borayo borayo self-assigned this Sep 16, 2025
@borayo borayo added this to Codedang Sep 16, 2025
@github-project-automation github-project-automation bot moved this to Pending ✋ in Codedang Sep 16, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Sep 16, 2025

Images automagically compressed by Calibre's image-actions ✨

Compression reduced images by 76.7%, saving 880.6 KB.

Filename Before After Improvement Visual comparison
apps/frontend/public/banners/main_banner.png 856.0 KB 175.8 KB 79.5% View diff
apps/frontend/public/banners/mainpage_middle_banner.png 292.3 KB 91.9 KB 68.5% View diff

@github-actions
Copy link
Contributor

github-actions bot commented Sep 16, 2025

Images automagically compressed by Calibre's image-actions ✨

Compression reduced images by 13.3%, saving 35.7 KB.

Filename Before After Improvement Visual comparison
apps/frontend/public/banners/mainpage_middle_banner.png 91.9 KB 70.8 KB 22.9% View diff
apps/frontend/public/banners/main_banner.png 175.8 KB 161.1 KB 8.3% View diff

@skkuding-bot
Copy link

skkuding-bot bot commented Sep 16, 2025

❗ Syncing Preview App Failed

Application: frontend
Revision: 87593bf31233d910b9bb99e5033478a68828ec15
Health Status: Degraded

Open Preview | View in Argo CD

@github-actions
Copy link
Contributor

github-actions bot commented Sep 16, 2025

Images automagically compressed by Calibre's image-actions ✨

Compression reduced images by 9.9%, saving 23.1 KB.

Filename Before After Improvement Visual comparison
apps/frontend/public/banners/mainpage_middle_banner.png 70.8 KB 58.2 KB 17.8% View diff
apps/frontend/public/banners/main_banner.png 161.1 KB 150.7 KB 6.5% View diff

@skkuding-bot
Copy link

skkuding-bot bot commented Sep 16, 2025

❗ Syncing Preview App Failed

Application: frontend
Revision: d5d9bd0644d98b6a4336109a9b17b04a9e1edf78
Health Status: Degraded

Open Preview | View in Argo CD

@jwoojin9
Copy link
Contributor

jwoojin9 commented Sep 16, 2025

https://raw.githubusercontent.com/skkuding/codedang/82df049597be870ea6214c36a15ff3c27e10daf3/apps/frontend/public/banners/main_banner.png
https://raw.githubusercontent.com/skkuding/codedang/d8f023a7ac8593e6443bdaa1a4c5cabbc0258bc9/apps/frontend/public/banners/main_banner.png

두 파일의 화질 차이(우상단 행성 주목!)를 보면 아시겠지만, 이미지 용량을 줄여주는 'Compress Images'라는 github action이 상시 돌아가고 있는데, 메인 배너처럼 화질이 중요한 파일일 경우 disable workflow를 한 다음에 커밋을 푸쉬해야 화질 저하를 막을 수 있습니다!
아마 권한이 없으실 텐데, 프론트 회의 때 같이 하는 게 좋을 것 같네요!

@borayo borayo closed this Sep 17, 2025
@github-project-automation github-project-automation bot moved this from Pending ✋ to Done ✔️ in Codedang Sep 17, 2025
@borayo borayo reopened this Sep 17, 2025
@github-project-automation github-project-automation bot moved this from Done ✔️ to Pending ✋ in Codedang Sep 17, 2025
@skkuding-bot
Copy link

skkuding-bot bot commented Sep 17, 2025

✅ Syncing Preview App Succeeded

Application: frontend
Revision: d5d9bd0644d98b6a4336109a9b17b04a9e1edf78
Health Status: Healthy

Open Preview | View in Argo CD

seoeun9
seoeun9 reviewed Sep 17, 2025
View reviewed changes
@github-actions
Copy link
Contributor

github-actions bot commented Sep 22, 2025

Images automagically compressed by Calibre's image-actions ✨

Compression reduced images by 12%, saving 7.0 KB.

Filename Before After Improvement Visual comparison
apps/frontend/public/banners/mainpage_middle_banner.png 58.2 KB 51.2 KB 12.0% View diff

1 image did not require optimisation.

@skkuding-bot
Copy link

skkuding-bot bot commented Sep 22, 2025

❗ Syncing Preview App Failed

Application: frontend
Revision: b1a31a3e58edab7b1ea7cf9fccf90f87df64e20c
Health Status: Degraded

Open Preview | View in Argo CD

@skkuding-bot
Copy link

skkuding-bot bot commented Sep 22, 2025

✅ Syncing Preview App Succeeded

Application: frontend
Revision: 7792ad28fc2b211d9ad48d52f8c231f4c38e31c7
Health Status: Healthy

Open Preview | View in Argo CD

@skkuding-bot
Copy link

skkuding-bot bot commented Sep 22, 2025

✅ Syncing Preview App Succeeded

Application: frontend
Revision: 60e1ece8f930d7f994579e896c831530bc7cda49
Health Status: Healthy

Open Preview | View in Argo CD

egg-zz
egg-zz approved these changes Sep 25, 2025
View reviewed changes
Copy link
Contributor

@egg-zz egg-zz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨음다

@github-project-automation github-project-automation bot moved this from Pending ✋ to Approved 👌 in Codedang Sep 25, 2025
seoeun9
seoeun9 approved these changes Sep 25, 2025
View reviewed changes
Copy link
Contributor

@seoeun9 seoeun9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿굿 고생하셨어요~~

@github-actions
Copy link
Contributor

github-actions bot commented Sep 25, 2025

Images automagically compressed by Calibre's image-actions ✨

Compression reduced images by 77.2%, saving 960.3 KB.

Filename Before After Improvement Visual comparison
apps/frontend/public/banners/main_banner.png 903.5 KB 181.6 KB 79.9% View diff
apps/frontend/public/banners/middle_banner.png 340.7 KB 102.4 KB 69.9% View diff

@skkuding-bot
Copy link

skkuding-bot bot commented Sep 25, 2025

❗ Syncing Preview App Failed

Application: frontend
Revision: d74b3679d3c923a128edd38b2b8b6032cb6743e5
Health Status: Degraded

Open Preview | View in Argo CD

@borayo borayo enabled auto-merge September 25, 2025 11:58
@seoeun9
Copy link
Contributor

seoeun9 commented Sep 26, 2025

이미지 재업로드 한번만 더 해보시는 건 어때요,,? 🥺

@github-actions
Copy link
Contributor

github-actions bot commented Sep 26, 2025

Images automagically compressed by Calibre's image-actions ✨

Compression reduced images by 11.1%, saving 31.5 KB.

Filename Before After Improvement Visual comparison
apps/frontend/public/banners/middle_banner.png 102.4 KB 82.3 KB 19.7% View diff
apps/frontend/public/banners/main_banner.png 181.6 KB 170.1 KB 6.3% View diff

@skkuding-bot
Copy link

skkuding-bot bot commented Sep 26, 2025

❗ Syncing Preview App Failed

Application: frontend
Revision: 1c296e2c515da8e050d0e5e1192f1c3a93ebeb39
Health Status: Degraded

Open Preview | View in Argo CD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seoeun9 seoeun9 seoeun9 approved these changes

@egg-zz egg-zz egg-zz approved these changes

Assignees

@borayo borayo

Labels

🌊 squad-__init__ ⛳️ team-frontend

Projects

Codedang
Status: Approved 👌

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@borayo @jwoojin9 @seoeun9 @egg-zz @Clover229