Fix regex to properly validate non-negative integer strings#3
Open
endelwar wants to merge 1 commit intoskleeschulte:masterfrom
Open
Fix regex to properly validate non-negative integer strings#3endelwar wants to merge 1 commit intoskleeschulte:masterfrom
endelwar wants to merge 1 commit intoskleeschulte:masterfrom
Conversation
Updated the regex in the validation logic to ensure the entire string consists solely of digits, preventing invalid inputs with mixed characters.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes the validation logic in the function that checks whether a given value is a positive integer (or a string representing a positive integer). The previous regex pattern '/[0-9]+/' only checked for the presence of one or more numeric characters but allowed invalid inputs like "abc123" or "123abc".
The updated regex '/^[0-9]+$/' ensures that the entire string consists solely of digits, representing a valid non-negative integer. This guarantees the proper validation of inputs.