Fix crash: wrap transcription coroutine in try/catch#3
Open
deepseven wants to merge 1 commit intoskorokithakis:masterfrom
Open
Fix crash: wrap transcription coroutine in try/catch#3deepseven wants to merge 1 commit intoskorokithakis:masterfrom
deepseven wants to merge 1 commit intoskorokithakis:masterfrom
Conversation
The fire-and-forget scope.launch(Dispatchers.IO) block that runs transcription has no top-level exception handler. If TranscriptionClient.transcribe() throws an unexpected exception (e.g. malformed URL, SSL error, OOM), it propagates as an uncaught coroutine exception and crashes the entire app process. The crash is particularly bad because the app restarts, syncs again, re-downloads the same file, tries to transcribe again, and crashes in an infinite loop. Fix: wrap the coroutine body in try/catch so transcription errors are logged but never kill the sync service.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fire-and-forget scope.launch(Dispatchers.IO) block that runs transcription has no top-level exception handler. If TranscriptionClient.transcribe() throws an unexpected exception (e.g. malformed URL, SSL error, OOM), it propagates as an uncaught coroutine exception and crashes the entire app process.
The crash is particularly bad because the app restarts, syncs again, re-downloads the same file, tries to transcribe again, and crashes in an infinite loop.
Fix: wrap the coroutine body in try/catch so transcription errors are logged but never kill the sync service.