Bloxy Version 6 by Syrilai · Pull Request #287 · skriken/bloxy

Syrilai · 2022-01-07T05:21:23Z

This PR (and branch) updates bloxy to version 6.

No information yet to this other than it will fix a lot of problems.

To-Do:

Update APIs

APIs:

Critical Changes

CaptchaAPI was removed
AdsAPI was removed
TradesAPI was removed

…`convertObjectToValue`

…t step

package.json

src/controllers/rest/response/RESTResponse.ts

guidojw · 2022-01-08T15:17:39Z

Commented everything I done on my fork (+ #279 & #280)

guidojw · 2022-01-08T15:30:22Z

Is there a reason why you didn't choose to use export * from './path' syntax in index.ts?

jaydns · 2022-01-08T15:33:19Z

src/client/lib/ClientSocket/ClientSocket.ts

-    connect (): Promise<void> {
-        return new Promise((resolve, reject) => {
-            const connectSocket = (retries = 0): void => {
-                this.socket = new SignalR.client("wss://realtime.roblox.com/notifications", ["usernotificationhub"], 3, true);


Consider replacing usage of signalr-client (deprecated) with https://www.npmjs.com/package/signalr

Do you perhaps know if Roblox uses ASP.NET or ASP.NET Core? Since Microsoft offers a signalr client as well (https://www.npmjs.com/package/@microsoft/signalr) which targets ASP.NET Core (and I'm not entirely sure if it also works with ASP.NET SignalR servers)

Do you perhaps know if Roblox uses ASP.NET or ASP.NET Core? Since Microsoft offers a signalr client as well (npmjs.com/package/@microsoft/signalr) which targets ASP.NET Core (and I'm not entirely sure if it also works with ASP.NET SignalR servers)

Fairly certain @microsoft/signalr only works with ASP.NET Core SignalR servers, and signalr only works with Normal ASP.NET SignalR servers. Both signalr and @microsoft/signalr are published by the same person on NPM -- wouldn't make much sense to publish a redundant package.

Roblox uses ASP.NET on realtime.roblox.com, judging by the headers. So signalr is the proper package to use.

Roblox uses both SignalR for .NET Core and .NET Framework. But for the likes of Messaging Service (Message Router Service) and Real-Time notifications, which are both part of the BEDEV1 Framework (Primarily .NET Framework, becoming obsolete), they use Microsoft’s Owin integration of SignalR

Co-authored-by: Guido de Jong <35309288+guidojw@users.noreply.github.com>

Syrilai · 2022-01-08T21:43:26Z

Commented everything I done on my fork (+ #279 & #280)

@guidojw Guessing because I worked the entire night, and I did the imports at around 7 am. Should be changed with the next commit that I have on hand, just need to update all typings in the apis first.

jaydns · 2022-01-20T04:21:55Z

compiled typescript output should stay in gitignore since it's not source files and can just be recompiled

Syrilai · 2022-01-20T13:30:35Z

compiled typescript output should stay in gitignore since it's not source files and can just be recompiled

This allows to install the branch with npm and will only stay for a bit

guidojw · 2022-02-27T02:18:49Z

After some digging, I finally found the cause of the error where X-CSRF token refreshing doesn't always correctly work:

The status message handler lowercases the received status message before comparing it to the set allowed/disallowed status messages. The set token validation error status message includes uppercase letters so this fails: https://github.com/Visualizememe/bloxy/blob/ea5281d6e99013bec5a57cc886bb85fa5ea861c4/src/controllers/rest/request/prepare.ts#L50

A good fix would be lowercasing statusMessage here
https://github.com/Visualizememe/bloxy/blob/ea5281d6e99013bec5a57cc886bb85fa5ea861c4/src/controllers/rest/response/handlers/validStatusMessage.ts#L18 and here https://github.com/Visualizememe/bloxy/blob/ea5281d6e99013bec5a57cc886bb85fa5ea861c4/src/controllers/rest/response/handlers/validStatusMessage.ts#L22

Although not really relevant for this PR, it seems like a good fix to include here.

guidojw · 2022-02-27T02:19:11Z

Also what's the timeline on this? ~~I see the bloxyjs/core repository, is that gonna be the new home for this project?~~ I read the linked issue, and seems like this is already on there 👍🏿

Syrilai · 2022-02-27T04:06:07Z

Also what's the timeline on this? ~~I see the bloxyjs/core repository, is that gonna be the new home for this project?~~ I read the linked issue, and seems like this is already on there 👍🏿

Yeah, bloxyjs/core is the new repository, since Martini unfortunately still did not manage to transfer the repository

Fix package, update package versions, enforce node v16

fdc8527

Syrilai self-assigned this Jan 7, 2022

Syrilai added 5 commits January 7, 2022 07:14

Remove captcha api (#281)

64095ab

Remove captcha api fully (#281)

2b92729

Add .prettierrc

a7c9de1

Export all types (#264)

b84c0c1

Fix CircleCI errors (npm run eslint)

0fff134

Syrilai linked an issue Jan 7, 2022 that may be closed by this pull request

Export types in index.ts #264

Open

Syrilai added 8 commits January 7, 2022 22:10

Use got as http package again

b8eb2a8

Switch from Jest to Mocha, rewrite tests

7da9a49

Run prettier, fix REST typings

4216bee

Update eslintrc.json, ignore security/detect-object-injection in …

b9bfa13

…`convertObjectToValue`

Update all files to respect the new .eslintrc.json

08df677

Update typescript devDependency, remove jest devDependency

8e3a4c7

Update the first few APIs to a newer state

67e09ae

Update all APIs to a certain extend, strip all structures for the nex…

c12e685

…t step

guidojw reviewed Jan 8, 2022

View reviewed changes

package.json Outdated Show resolved Hide resolved

guidojw reviewed Jan 8, 2022

View reviewed changes

src/controllers/rest/response/RESTResponse.ts Outdated Show resolved Hide resolved

jaydns reviewed Jan 8, 2022

View reviewed changes

Remove postinstall from package.json

e2b5f41

Co-authored-by: Guido de Jong <35309288+guidojw@users.noreply.github.com>

This comment has been minimized.

Sign in to view

Syrilai and others added 3 commits January 8, 2022 22:27

Change typedoc to use typedoc.json

de6c56c

Merge removal of postinstall

f0cbe7c

Fix RESTResponse.ts to respect the right error name

7860347

Co-authored-by: Guido de Jong <35309288+guidojw@users.noreply.github.com>

Syrilai added 2 commits January 9, 2022 04:36

Add a suffix to all types in the api files

598e574

Merge branch 'v6' of https://github.com/Visualizememe/bloxy into v6

02687a4

Syrilai added this to the v6 milestone Jan 9, 2022

Syrilai added the v6 label Jan 9, 2022

Syrilai added 6 commits January 9, 2022 07:59

FIX TYPEDOC

b513358

Remove default exports

12d6040

Fix unit tests

b1c1e74

Rewrite BaseUser and User, documented it

bfcfca5

Include the dist folder

3c277dc

Build to latest state

ea5281d

Conversation

Syrilai commented Jan 7, 2022 • edited by skriken Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Critical Changes

Uh oh!

Uh oh!

Uh oh!

guidojw commented Jan 8, 2022

Uh oh!

guidojw commented Jan 8, 2022

Uh oh!

jaydns Jan 8, 2022

Choose a reason for hiding this comment

Uh oh!

Syrilai Jan 8, 2022

Choose a reason for hiding this comment

Uh oh!

jaydns Jan 8, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nikita-petko Jan 20, 2022

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

Syrilai commented Jan 8, 2022

Uh oh!

jaydns commented Jan 20, 2022

Uh oh!

Syrilai commented Jan 20, 2022

Uh oh!

guidojw commented Feb 27, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

guidojw commented Feb 27, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Syrilai commented Feb 27, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Syrilai commented Jan 7, 2022 •

edited by skriken

Loading

jaydns Jan 8, 2022 •

edited

Loading

guidojw commented Feb 27, 2022 •

edited

Loading

guidojw commented Feb 27, 2022 •

edited

Loading