Added rescan interval

[MystaraTheGreat]

Added rescan interval as an option to rescan the image repository periodically.

[skuethe]

Thanks for the PR. I'll have a look at it when I have time.

[skuethe]

Please use the same indentation as the rest of the code. So no tab's, only spaces.

[skuethe]

Please use the same indentation as the rest of the code. So no tab's, only spaces.

Thanks for your fast updates. I saw you pushed changes to README concerning the tab to spaces change.
But it was especially meant for the MMM-RandomPhoto.js file :) The README.md is not that critical when it comes to tabs

[skuethe]

The problem with this timer is, that it will conflict with the updateInterval timer.
Also, when you have startPaused set to true it will still reload the images and continue with the image cycle on every scanInterval trigger. This breaks usage of the startPaused setting and somewhat the one of updateInterval.

So we need to think of a way to respect these settings before triggering a reload.

[MystaraTheGreat]

1. Conflict

Could you please explain this in more detail? I'm not really sure I see how there's a conflict. The two timers should be independent.

2. startPaused set to true

I think the issue is that this.load() is getting called on line 107 when startPaused is set to true? Consequently even though startPaused is set to true, the image will keep cycling.

So to fix that, the IMAGE_LIST notification needs to be disconnected from loading an image - at least after an image has already been loaded?

[skuethe]

1. Conflict

Well this also has to do with the fact that we are calling this.load() on every IMAGE_LIST notification received. In this case both timers are triggering the load of the next image. That's what I mean with "conflict".

2. startPaused set to true

Well this.load() is always called in the resumeImageLoading function. Regardless of what startPaused is set to.
startHidden actually handles the call when receiving the notification.

After giving it a bit of thought, it is probably best to just get rid of lines 411 to 413.

We are calling the resumeImageLoading function already during MM²'s extended build-in resume function. So that should get the image loading started in the first place.

But this needs to be tested to see if the app behaves like it should with all the different config settings - especially startHidden and startPaused.

[MystaraTheGreat]

Okay. It does look as if they would solve the initial issue. But I agree that it's necessary to check the startHidden and startPaused. I'll give it a go here and see what happens.

[MystaraTheGreat]

Hm, no, doesn't seem to work. The image loading never starts.
A messier fix might be to add a firstImageLoaded flag to indicate whether a first image has loaded or not - and not to call resumeImageLoading if firstImageLoaded is true.

But it seems inelegant.

[skuethe]

If we delete lines 411 to 413 we need to also adjust these lines.
But the problem actually still persists. No display is being shown, because the image loading just takes more time.
So actually invoking the image showing on the IMAGE_LIST socketNotification still makes sense (lines 411 to 413).

So I would agree the easiest solution probably is to introduce some kind of flag / parameter to indicate if it is an "initial image loading" process or an "update image loading" process.

Some thoughts without going deeper into details:

• maybe add an additional UPDATE_IMAGE_LIST socketNotification?
• somehow wait for this.imageList's lenght to be > 0?
• maybe work with async and await to wait for some executions?

[MystaraTheGreat]

I'm now testing a version that uses an UPDATE_IMAGE_LIST socket notification. On reception, all it does it replace the imageList. It doesn't do anything regarding resumption.

I haven't followed up on waiting for the imageList length to be >0 or using async/wait. These changes don't seem to be necessary?

[MystaraTheGreat]

The above version seems to work. However, I've been having difficulty with the calendar not updating as well, so I'm going to take the simpler option of just restarting MM every day.

Feel free to use the push or not as you like :)