-
Notifications
You must be signed in to change notification settings - Fork 0
AB#492654 change UUID library #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR addresses a security vulnerability by migrating from the github.com/satori/go.uuid library to github.com/google/uuid, and modernizes the codebase by refactoring interface{} to any throughout.
Key Changes:
- Replaced UUID library dependency from
satori/go.uuidtogoogle/uuid(v1.6.0) with corresponding API update (uuid.FromString→uuid.Parse) - Systematically refactored all occurrences of
interface{}toanyacross the codebase
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| go.mod | Updated UUID library dependency from satori/go.uuid to google/uuid v1.6.0 |
| go.sum | Updated checksums for new google/uuid dependency and removed old satori/go.uuid entries |
| mapvalue/mapvalue.go | Updated UUID import and API call; refactored all function signatures and type assertions from interface{} to any |
| mapvalue/mapvalue_test.go | Refactored all test type declarations from interface{} to any for consistency |
| middlewares/context.go | Refactored all type assertions and map declarations from interface{} to any |
| redis/client.go | Updated Marshal and Unmarshal function signatures to use any instead of interface{} |
| redis/client_test.go | Updated test struct field type from interface{} to any |
| cache/cache.go | Updated function return types and map declarations from interface{} to any |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
acofer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://www.reddit.com/r/golang/comments/1kmh4cc/is_githubcomgoogleuuid_abandoned/
Let's instead use https://github.com/gofrs/uuid, which is maintained and also is explicit about generating v4 UUIDs
Nice suggestion, done |
Issue Link
https://dev.azure.com/nintex/Nintex/_workitems/edit/492654
High-Level Description
Warden, Clortho, Picard - Review go.uuid Vulnerability regarding Insecure UUID Identifiers
Changelog: